CMake/deps: XR_OpenXR v1.0.14
ClosedPublic
Actions

Authored by Ray Molenkamp (LazyDodo) on Feb 6 2021, 9:15 PM.

Details

Reviewers

Sebastián Barschkis (sebbas)
Sybren A. Stüvel (sybren)

Commits

rBda0c5e7224e1: CMake/Deps: XR_OpenXR v1.0.14

Summary

Straight up version bump

Things of note:

they started using API calls only available
in windows 8, however given the python update
will forcibly bump us to 8.1+ anyhow this is not
an issue.

Will require some minor tweaks to platform_win32.cmake
after adding the libs to svn which are not included
in this diff so this diff can land without having to have
the libs in place yet.

Diff Detail

Repository

rB Blender

Branch

tmp_openxr_1_0_14 (branched from master)

Build Status

Buildable 12695
Build 12695: arc lint + arc unit

Event Timeline

Ray Molenkamp (LazyDodo) created this revision.Feb 6 2021, 9:15 PM

Harbormaster completed remote builds in B12695: Diff 33675.Feb 6 2021, 9:15 PM

Ray Molenkamp (LazyDodo) requested review of this revision.Feb 6 2021, 9:15 PM

Ray Molenkamp (LazyDodo) mentioned this in T85365: Libraries Changes for Blender 2.93.Feb 6 2021, 9:16 PM

If the name of the debug library is changed here, doesn't XR_OPENXR_SDK_LIBRARIES have to be changed in platform_win32 as well? Or did you only want to do platform agnostic changes here?
EDIT: NVM, you explained it in the description :)

Otherwise looks good, checking with my updating notes, nothing else should be needed.

Sybren A. Stüvel (sybren) accepted this revision.Feb 12 2021, 1:00 PM

This revision is now accepted and ready to land.Feb 12 2021, 1:00 PM

Sebastián Barschkis (sebbas) accepted this revision.Feb 12 2021, 1:34 PM

Closed by commit rBda0c5e7224e1: CMake/Deps: XR_OpenXR v1.0.14 (authored by Ray Molenkamp (LazyDodo), committed by Sybren A. Stüvel (sybren)). · Explain WhyFeb 15 2021, 12:17 PM

This revision was automatically updated to reflect the committed changes.

Sybren A. Stüvel (sybren) added a commit: rBda0c5e7224e1: CMake/Deps: XR_OpenXR v1.0.14.