UI: Improved feedback when dropping is not possible on drag 'n drop
ClosedPublic
Actions

Authored by Julian Eisel (Severin) on Feb 8 2021, 2:25 PM.

Details

Reviewers

None

Group Reviewers

User Interface

Commits

rBdf2e05393533: UI: Improved feedback when dropping is not possible on drag 'n drop

Summary

Allow operators to show a "disabled hint" in red text explaining why dropping at the current location and in current context doesn't work. Should greatly help users to understand what's the problem.
Show a "stop" cursor when dropping isn't possible, like it's common on OSes.

As an example, this adds a disabled hint to the object dropping operator.

On macOS:

Part of T85342.

Diff Detail

Repository: rB Blender

Event Timeline

Julian Eisel (Severin) requested review of this revision.Feb 8 2021, 2:25 PM

Julian Eisel (Severin) created this revision.

Harbormaster completed remote builds in B12716: Diff 33710.Feb 8 2021, 2:25 PM

The cursor isn't reset correctly to the edit mode one, please ignore that right now. I just want to quickly propose the design change.

Julian Eisel (Severin) added a project: User Interface.Feb 8 2021, 2:41 PM

How about Only supported in Object mode.? Since the "dropping" part is implied by the dragging.

I agree with Pablo, I suggested the same thing in chat. Otherwise this looks like a nice improvement.

Yeah, I'm just wondering: Is it clear that the string explains why it is disabled (despite the red), without the "Dropping not possible:"? If it is a bit longer, maybe people will just not bother to read it?
I may be overthinking though.

I think it's clear not only by the color but also the message being shorter can be read faster.

Adding the asset browser tag, as I think it's important for some dragging operations in the asset browser. E.g. dragging assets from an external file onto catalogs should show a message that this isn't possible.

Pablo Vazquez (pablovazquez) awarded a token.Oct 12 2021, 12:40 PM

Julian Eisel (Severin) mentioned this in T92434: Improve feedback when dragging assets into catalog isn't possible.Oct 23 2021, 4:37 PM

Adapt to changes in master
Remove unnecessary "Dropping not possible:" prefix

Harbormaster completed remote builds in B18195: Diff 43896.Oct 25 2021, 3:49 PM

This will need another update once D12948: Drag Drop: allow customizable drawing is in (should happen any minute). Think this should also make it easier for me to fix the stop cursor that is not being reset correctly right now.

Proper cursor hanldling & fix double disabled-hint when dragging assets

Harbormaster completed remote builds in B18244: Diff 43985.Oct 26 2021, 5:56 PM

Julian Eisel (Severin) retitled this revision from Proposal: Improved feedback when dropping is not possible on drag 'n drop to UI: Improved feedback when dropping is not possible on drag 'n drop.Oct 26 2021, 6:02 PM

This revision was not accepted when it landed; it landed in state Needs Review.Oct 26 2021, 6:17 PM

Closed by commit rBdf2e05393533: UI: Improved feedback when dropping is not possible on drag 'n drop (authored by Julian Eisel (Severin)). · Explain Why

This revision was automatically updated to reflect the committed changes.

Julian Eisel (Severin) added a commit: rBdf2e05393533: UI: Improved feedback when dropping is not possible on drag 'n drop.