Page MenuHome
Differential D10359

CMake/Deps: TBB 2020U2
ClosedPublic
Actions

Authored by Ray Molenkamp (LazyDodo) on Feb 8 2021, 3:56 PM.

Details

Reviewers
Sybren A. Stüvel (sybren)
Sebastián Barschkis (sebbas)
Commits
rB227fa68696a2: CMake/Deps: TBB 2020U2
Summary

Straight forward version bump, since the source
files are globbed had to exclude one manually
(file is not build in their official build system
either so it's safe)

2020U2 is significantly louder in the deprecated
header usage warning department, we should probably
see if we need to act on this. P1949

Diff Detail

Repository
rB Blender
Branch
tmp_tbb (branched from master)
Build Status
Buildable 12727
Build 12727: arc lint + arc unit

Event Timeline

Ray Molenkamp (LazyDodo) requested review of this revision.Feb 8 2021, 3:56 PM
Ray Molenkamp (LazyDodo) created this revision.
Harbormaster completed remote builds in B12718: Diff 33713.Feb 8 2021, 3:56 PM
Ray Molenkamp (LazyDodo) mentioned this in T85365: Libraries Changes for Blender 2.93.Feb 8 2021, 3:57 PM
Brecht Van Lommel (brecht) mentioned this in D10361: TBB: fix deprecation warnings with newer TBB versions.Feb 8 2021, 7:34 PM
Brecht Van Lommel (brecht) added a comment.Feb 8 2021, 7:42 PM

I'll probably commit D10361: TBB: fix deprecation warnings with newer TBB versions tomorrow to fix the warnings ahead of the library update.

The new warnings are really coming from USD and OpenVDB headers, which we can't fix, just suppress.

Ray Molenkamp (LazyDodo) updated this revision to Diff 33727.EditedFeb 8 2021, 8:04 PM
  • Include TBB pull #299 to fix compatibility with MSVC 2017

More strange guidance from the VFX platform, the TBB version and the compiler version recommended for windows are not compatible

Harbormaster completed remote builds in B12727: Diff 33727.Feb 8 2021, 8:04 PM
Sebastián Barschkis (sebbas) accepted this revision.Feb 10 2021, 9:42 AM

All good on macOS.

This revision is now accepted and ready to land.Feb 10 2021, 9:42 AM
Brecht Van Lommel (brecht) mentioned this in rB677e63d51869: TBB: fix deprecation warnings with newer TBB versions.Feb 10 2021, 7:32 PM
Sybren A. Stüvel (sybren) accepted this revision.Feb 12 2021, 4:53 PM
Sybren A. Stüvel (sybren) mentioned this in D10406: CMake/Deps: OpenImageDenoise 1.2.3 → 1.3.0.Feb 12 2021, 5:12 PM
Closed by commit rB227fa68696a2: CMake/Deps: TBB 2020U2 (authored by Ray Molenkamp (LazyDodo), committed by Sybren A. Stüvel (sybren)). · Explain WhyFeb 15 2021, 12:17 PM
This revision was automatically updated to reflect the committed changes.
Sybren A. Stüvel (sybren) added a commit: rB227fa68696a2: CMake/Deps: TBB 2020U2.
Stefan Werner (swerner) mentioned this in rC67cb95b3556a: TBB: fix deprecation warnings with newer TBB versions.Jun 2 2021, 9:16 PM

Revision Contents
Changeset List

PathSize
build_files/
build_environment/
cmake/
3 lines
4 lines
patches/
1 line
13 lines

Diff 33727

View Options

build_files/build_environment/cmake/tbb.cmake

Loading...
View Options

build_files/build_environment/cmake/versions.cmake

Loading...
View Options

build_files/build_environment/patches/cmakelists_tbb.txt

Loading...
View Options

build_files/build_environment/patches/tbb.diff

Loading...