Page MenuHome
Differential D10369

Fix T85499: Crash on switching to edit mode with uv editor open
ClosedPublic
Actions

Authored by Falk David (filedescriptor) on Feb 9 2021, 2:41 PM.

Details

Reviewers
Jeroen Bakker (jbakker)
Campbell Barton (campbellbarton)
Maniphest Tasks
T85495: Crash when entering Armature Edit mode in 3D Viewport aside a UV Editor split window
T85499: Edit Curve Crash
Commits
rB3e55d7d60542: Fix T85499: Crash on switching to edit mode with uv editor open
Summary

A fix for T83187 (rBf83aa830) assumed in the overlay code of the uv editor that the object was a mesh
when it did not have to be - causing a crash.

The fix makes sure that the object is a mesh.

Diff Detail

Repository
rB Blender

Event Timeline

Falk David (filedescriptor) requested review of this revision.Feb 9 2021, 2:41 PM
Falk David (filedescriptor) created this revision.
Falk David (filedescriptor) added a task: T85499: Edit Curve Crash.
Falk David (filedescriptor) edited the summary of this revision. (Show Details)Feb 9 2021, 2:44 PM
Jeroen Bakker (jbakker) requested changes to this revision.Feb 9 2021, 4:54 PM

Just a small change needed to skip some unneeded CPU cycles.

source/blender/draw/engines/overlay/overlay_edit_uv.c
410

I would move this one line up and check against objects[ob_index] so the depsgraph call is also skipped.

This revision now requires changes to proceed.Feb 9 2021, 4:54 PM
Falk David (filedescriptor) updated this revision to Diff 33777.Feb 9 2021, 6:01 PM
Falk David (filedescriptor) edited the summary of this revision. (Show Details)

Made changes as requested

Harbormaster completed remote builds in B12754: Diff 33777.Feb 9 2021, 6:01 PM
炎臻 (PrettyFireNOI7) added a subscriber: 炎臻 (PrettyFireNOI7).Feb 10 2021, 4:28 AM
Jeroen Bakker (jbakker) accepted this revision.Feb 10 2021, 1:20 PM
This revision is now accepted and ready to land.Feb 10 2021, 1:20 PM
Campbell Barton (campbellbarton) requested changes to this revision.Feb 11 2021, 4:12 AM
Campbell Barton (campbellbarton) added a subscriber: Campbell Barton (campbellbarton).

In this case you can check if draw_ctx->obact is a mesh before allocating objects and looping over them.

This revision now requires changes to proceed.Feb 11 2021, 4:12 AM
炎臻 (PrettyFireNOI7) mentioned this in T85495: Crash when entering Armature Edit mode in 3D Viewport aside a UV Editor split window.Feb 12 2021, 2:44 AM
Falk David (filedescriptor) updated this revision to Diff 33900.Feb 12 2021, 1:00 PM
  • Move check outside of loop
Harbormaster completed remote builds in B12834: Diff 33900.Feb 12 2021, 1:01 PM
Falk David (filedescriptor) added a task: T85495: Crash when entering Armature Edit mode in 3D Viewport aside a UV Editor split window.Feb 15 2021, 10:46 AM
Jeroen Bakker (jbakker) accepted this revision.Feb 15 2021, 11:01 AM
Campbell Barton (campbellbarton) accepted this revision.Feb 15 2021, 11:56 AM
This revision is now accepted and ready to land.Feb 15 2021, 11:56 AM
Falk David (filedescriptor) updated this revision to Diff 34012.Feb 15 2021, 8:10 PM

Merge

Harbormaster completed remote builds in B12905: Diff 34012.Feb 15 2021, 8:10 PM
Closed by commit rB3e55d7d60542: Fix T85499: Crash on switching to edit mode with uv editor open (authored by Falk David (filedescriptor)). · Explain WhyFeb 15 2021, 8:11 PM
This revision was automatically updated to reflect the committed changes.
Falk David (filedescriptor) added a commit: rB3e55d7d60542: Fix T85499: Crash on switching to edit mode with uv editor open.
炎臻 (PrettyFireNOI7) awarded a token.Feb 16 2021, 5:33 AM

Revision Contents
Changeset List

PathSize
source/
blender/
draw/
engines/
overlay/
3 lines

Diff 34013

View Options

source/blender/draw/engines/overlay/overlay_edit_uv.c

Loading...