Page MenuHome

Fix T79999: Double color management applied during viewport animation render
ClosedPublic

Authored by Jeroen Bakker (jbakker) on Feb 9 2021, 3:35 PM.

Details

Summary

In 2.81 there was a change to increase the performance of viewport
animation rendering. This change would perform the color management on the
GPU if the only 8bit was needed. This saved CPU cycles and data
transfer.

The issue is that in the image editor or when saving the image the CM
will be reapplied. Although the speed is desired, exporting the actual
colors has more priority.

In the ticket there is an analysis that shows that shows that this fix
is the correct short term step to take. It would be better that the
render result is aware of the color space of its buffers so the applying
color management could be skipped when saving to disk or drawing in the
image editor.

The issue with this change is the performance penalty it has.

Diff Detail

Repository
rB Blender

Event Timeline

Jeroen Bakker (jbakker) requested review of this revision.Feb 9 2021, 3:35 PM
Jeroen Bakker (jbakker) edited the summary of this revision. (Show Details)Feb 9 2021, 3:36 PM
Jeroen Bakker (jbakker) edited the summary of this revision. (Show Details)
This revision is now accepted and ready to land.Feb 10 2021, 7:53 PM
Jeroen Bakker (jbakker) edited the summary of this revision. (Show Details)Feb 12 2021, 7:51 AM