Page MenuHome
Differential D10372

macOS: use find_package for finding Python
Needs ReviewPublic
Actions

Authored by Ankit Meel (ankitm) on Feb 9 2021, 3:53 PM.

Details

Reviewers
Brecht Van Lommel (brecht)
Group Reviewers
Platform: macOS
Summary

Avoid fiddling with trailing m or Python version or
paths like that of NumPy.

Accommodate Framework like from Homebrew for
bpy module.

Depends on D10368 because the CMake code internally
relies on import numpy which fails when NumPy
has a buggy backend.

Diff Detail

Repository
rB Blender
Branch
bpy (branched from master)
Build Status
Buildable 13425
Build 13425: arc lint + arc unit

Event Timeline

Ankit Meel (ankitm) requested review of this revision.Feb 9 2021, 3:53 PM
Ankit Meel (ankitm) created this revision.
Ankit Meel (ankitm) edited the summary of this revision. (Show Details)
Ankit Meel (ankitm) added a reviewer: Platform: macOS.Feb 9 2021, 3:56 PM
Ankit Meel (ankitm) added a project: Platform: macOS.
Brecht Van Lommel (brecht) accepted this revision as: Brecht Van Lommel (brecht).Feb 9 2021, 8:01 PM
This revision is now accepted and ready to land.Feb 9 2021, 8:01 PM
Sebastián Barschkis (sebbas) mentioned this in D10380: cmake: update python to 3.9.1.Feb 10 2021, 9:30 AM
Ankit Meel (ankitm) updated this revision to Diff 33823.Feb 10 2021, 11:04 AM

Fix typo

Brecht Van Lommel (brecht) mentioned this in T85365: Libraries Changes for Blender 2.93.Feb 12 2021, 3:18 PM
Blender Defender (Blender_Defender) awarded a token.Feb 15 2021, 5:10 PM
Ankit Meel (ankitm) added a subscriber: Sebastián Barschkis (sebbas).Feb 15 2021, 8:35 PM

@Sebastián Barschkis (sebbas) Expecting you to commit this after building numpy for x86_64, and also after resolving the CMake issues you were talking about in chat.

Sebastián Barschkis (sebbas) added a comment.Feb 15 2021, 8:36 PM

@Ankit Meel (ankitm) Sure thing, thanks for the patch!

Ankit Meel (ankitm) planned changes to this revision.Feb 26 2021, 10:34 PM

Mind if I hold it till next weekend and fix framework finding code too ?
I could do guesswork now, but don't want to break bpy build.

Ankit Meel (ankitm) updated this revision to Diff 35009.Mar 10 2021, 8:10 AM
  • Fix framework finding code too.

Since now CMake is looking in system folders, it might find other Python installations too.
The guarantee of finding only framework is not there as for Python_FIND_FRAMEWORK,
"ONLY" is not supported, next best thing is "FIRST". I tried a regex match if that's any
helpful.

This revision is now accepted and ready to land.Mar 10 2021, 8:10 AM
Harbormaster completed remote builds in B13395: Diff 35009.Mar 10 2021, 8:10 AM
Ankit Meel (ankitm) updated this revision to Diff 35010.Mar 10 2021, 8:10 AM

Fix arc mistake

Harbormaster completed remote builds in B13396: Diff 35010.Mar 10 2021, 8:10 AM
Ankit Meel (ankitm) updated this revision to Diff 35011.Mar 10 2021, 8:13 AM
  • Ask for exact version.
Harbormaster completed remote builds in B13397: Diff 35011.Mar 10 2021, 8:13 AM
Ankit Meel (ankitm) requested review of this revision.Mar 10 2021, 8:14 AM
Ankit Meel (ankitm) updated this revision to Diff 35054.Mar 11 2021, 9:34 AM
  • Fix library folder
Harbormaster completed remote builds in B13425: Diff 35054.Mar 11 2021, 9:34 AM
Ankit Meel (ankitm) updated this revision to Diff 41291.Aug 31 2021, 8:36 PM
  • Fix version, flip conditionals, fix PYTHON_VERSION conflict
  • Rebase
Harbormaster completed remote builds in B16734: Diff 41291.Aug 31 2021, 8:36 PM
Ankit Meel (ankitm) edited the summary of this revision. (Show Details)Aug 31 2021, 8:38 PM
Ankit Meel (ankitm) mentioned this in D14954: Switch to using CMake's FindPython3 module..May 23 2022, 2:06 PM

Revision Contents
Changeset List

PathSize
build_files/
cmake/
platform/
64 lines

Diff 35054

View Options

build_files/cmake/platform/platform_apple.cmake

Loading...