Page MenuHome
Differential D10375

Fix issue with render_passes AOVs in viewport
ClosedPublic
Actions

Authored by Ulysse Martin (youle) on Feb 9 2021, 7:07 PM.

Details

Reviewers
Jeroen Bakker (jbakker)
Philipp Oeser (lichtwerk)
Commits
rB75580fa6a661: Fix flashing eevee render passes in viewport
Summary

Since https://developer.blender.org/rB85fe12071ad7f7f866b2f2e213ee291dc607b38d , when we look at current AOV pass in viewport and move the camera, there's a "flash" effect in this AOVs test file:

AOVsTest.blend871 KBDownload

The cause seems to be that taa_current_sample when rendering (DRW_state_is_image_render() ) is ok because it has been incremented in EEVEE_temporal_sampling_draw but taa_current_sample is wrong when we are not rendering.

Diff Detail

Event Timeline

Ulysse Martin (youle) requested review of this revision.Feb 9 2021, 7:07 PM
Ulysse Martin (youle) created this revision.
Jacob Merrill (blueprintrandom) added a subscriber: Jacob Merrill (blueprintrandom).Feb 9 2021, 7:55 PM
Evan Wilson (EAW) awarded a token.Feb 10 2021, 5:04 AM
Philipp Oeser (lichtwerk) accepted this revision.Feb 10 2021, 9:15 AM
Philipp Oeser (lichtwerk) added a reviewer: Jeroen Bakker (jbakker).
Philipp Oeser (lichtwerk) added a subscriber: Jeroen Bakker (jbakker).

Can confirm the issue, thx noting and fixing.

Since TAA can be tricky regarding consequences, I would like to have @Jeroen Bakker (jbakker) review this.

Jeroen Bakker (jbakker) accepted this revision.Feb 10 2021, 1:19 PM
This revision is now accepted and ready to land.Feb 10 2021, 1:19 PM
Blender Defender (Blender_Defender) awarded a token.Feb 15 2021, 5:10 PM
Closed by commit rB75580fa6a661: Fix flashing eevee render passes in viewport (authored by Philipp Oeser (lichtwerk)). · Explain WhyFeb 18 2021, 11:07 AM
This revision was automatically updated to reflect the committed changes.
Philipp Oeser (lichtwerk) added a commit: rB75580fa6a661: Fix flashing eevee render passes in viewport.

Revision Contents
Changeset List

PathSize
source/
blender/
draw/
engines/
eevee/
4 lines

Diff 33779

View Options

source/blender/draw/engines/eevee/eevee_renderpasses.c

Loading...