Page MenuHome

Fix T85494: Moving 3d cursor will turn off prop edit
AbandonedPublic

Authored by Falk David (filedescriptor) on Feb 10 2021, 3:53 PM.

Details

Summary

Moving the 3d cursor would turn off proportional editing.
This was caused by rBe91d5811676c but due to the fact that
the use_proportional_edit property was set when it shouldnt.

The fix clears that flag so proportional editing will not affect
the cursor transform.

Diff Detail

Repository
rB Blender
Branch
T85494 (branched from master)
Build Status
Buildable 12790
Build 12790: arc lint + arc unit

Event Timeline

Falk David (filedescriptor) requested review of this revision.Feb 10 2021, 3:53 PM
Falk David (filedescriptor) created this revision.

Actually, the problem is another.

You can see what is happening in the saveTransform function in transfom.c.
If proportional edit is enabled during a transformation, this option is updated in the scene.
However, as the Cursor does not use this option, the code mistakenly sees this as if that option has been disabled and thus updates the scene.
If a value for "use_proportional_edit" is set, this update is skipped.

I have an idea of a different solution that makes the code safer and simpler.
I'm working on it.