Page MenuHome
Differential D10387

RNA: Support bool attribute in RNA.
ClosedPublic
Actions

Authored by Jacques Lucke (JacquesLucke) on Feb 10 2021, 5:05 PM.

Details

Reviewers
Hans Goudey (HooglyBoogly)
Commits
rBdabf96f732d1: Attributes: support bool attribute in rna
Summary

This is a prerequisite for D10210. Also it allows scripts to access bool attributes.

Diff Detail

Repository
rB Blender

Event Timeline

Jacques Lucke (JacquesLucke) requested review of this revision.Feb 10 2021, 5:05 PM
Jacques Lucke (JacquesLucke) created this revision.
Harbormaster completed remote builds in B12792: Diff 33834.Feb 10 2021, 5:05 PM
Jacques Lucke (JacquesLucke) edited the summary of this revision. (Show Details)Feb 10 2021, 5:05 PM
Jacques Lucke (JacquesLucke) added a reviewer: Hans Goudey (HooglyBoogly).
Hans Goudey (HooglyBoogly) accepted this revision.Feb 11 2021, 6:04 AM

I tested this by adding self.add_standard_attribute(layout, pointcloud, 'Boolean', 'BOOLEAN', 'POINT') in properties_data_pointcloud.py. Might as well include that in this patch?

In the outliner data API mode I could even affect a point separate node, though I had to trigger the recalculation manually.

This revision is now accepted and ready to land.Feb 11 2021, 6:04 AM
Closed by commit rBdabf96f732d1: Attributes: support bool attribute in rna (authored by Jacques Lucke (JacquesLucke)). · Explain WhyFeb 11 2021, 1:45 PM
This revision was automatically updated to reflect the committed changes.
Jacques Lucke (JacquesLucke) added a commit: rBdabf96f732d1: Attributes: support bool attribute in rna.
Jacques Lucke (JacquesLucke) added a comment.Feb 11 2021, 1:47 PM

Might as well include that in this patch?

Why should that be included?

I had to trigger the recalculation manually.

Sounds like something we could fix separately.

Revision Contents
Changeset List

PathSize
source/
blender/
makesdna/
3 lines
makesrna/
1 line
intern/
35 lines

Diff 33858

View Options

source/blender/makesdna/DNA_meshdata_types.h

Loading...
View Options

source/blender/makesrna/RNA_access.h

Loading...
View Options

source/blender/makesrna/intern/rna_attribute.c

Loading...