Fix T85545: Changing position attribute does not tag normals dirty.
ClosedPublic
Actions

Authored by Jacques Lucke (JacquesLucke) on Feb 11 2021, 12:32 PM.

Details

Reviewers

Hans Goudey (HooglyBoogly)

Maniphest Tasks

T85545: Wrong normals when using Attribute Sample Texture node to displace a grid mesh

Commits

rB9a7dc41dd9b9: Fix T85545: changing position attribute does not tag normals dirty

Summary

This makes it so that normals are tagged dirty whenever the position attribute is requested for writing. This seems like a good default. If the calling code is aware of normals, it could untag normals when they are not changed by the operation.

Diff Detail

Repository

rB Blender

Branch

tag-dirty-on-write (branched from master)

Build Status

Buildable 12806
Build 12806: arc lint + arc unit

Event Timeline

Jacques Lucke (JacquesLucke) requested review of this revision.Feb 11 2021, 12:32 PM

Jacques Lucke (JacquesLucke) created this revision.

Harbormaster completed remote builds in B12806: Diff 33855.Feb 11 2021, 12:32 PM

Jacques Lucke (JacquesLucke) edited the summary of this revision. (Show Details)Feb 11 2021, 12:35 PM

Jacques Lucke (JacquesLucke) added a reviewer: Hans Goudey (HooglyBoogly).

Jacques Lucke (JacquesLucke) added a project: Geometry Nodes.

Jacques Lucke (JacquesLucke) added a task: T85545: Wrong normals when using Attribute Sample Texture node to displace a grid mesh.

Hans Goudey (HooglyBoogly) accepted this revision.Feb 11 2021, 10:17 PM

Hans Goudey (HooglyBoogly) added inline comments.

source/blender/blenkernel/intern/attribute_access.cc
629	I wonder if the name should be slightly more general, this seems a bit specific to how this works for meshes. Maybe `update_on_write`? The specific function name provided for this field can give the required context anyway.