Page MenuHome

Cycles: Add option to change input passes for viewport denoising
ClosedPublic

Authored by Patrick Mours (pmoursnv) on Feb 12 2021, 1:50 PM.
Subscribers
None
Tokens
"Like" token, awarded by YAFU."Like" token, awarded by Maged_afra."Love" token, awarded by wo262.

Details

Summary

There are cases where the default of color+albedo does not actually yield useful results. T78571 is one example, volume rendering another.
For those cases one has to switch to just color as input for denoising to get correct results. While this was possible to do for final frame rendering (in the layer settings), viewport denoising always used a fixed color+albedo.
This adds an option to change the input passes for viewport denoising too, so that one can use it in scenes that otherwise wouldn't work well with it.


Only potential problem I'm seeing is that the option may cause confusion where it's currently placed, since for final frame rendering the same option is per-layer and therefore has to be found somewhere else.

Diff Detail

Repository
rB Blender
Branch
cycles_viewport_denoising_input_passes (branched from master)
Build Status
Buildable 13056
Build 13056: arc lint + arc unit

Event Timeline

Patrick Mours (pmoursnv) requested review of this revision.Feb 12 2021, 1:50 PM
Brecht Van Lommel (brecht) requested changes to this revision.Feb 18 2021, 7:22 PM

Seems fine. There could indeed be confusion with the view layer options, but not sure what would be a better solution.

intern/cycles/blender/addon/ui.py
292

I'd leave out "Viewport" from the label here, and put a separator() between render and viewport settings to make the grouping of options more clear..

This revision now requires changes to proceed.Feb 18 2021, 7:22 PM

How about this (explicitly stating that where the other settings are)?:

I'd rather not have that description. I can see how it's helpful, but we generally don't do this in the Blender UI and I think it gets in the way too much once it has been read.

If you leave that, this is fine with me.

Added separator between render and viewport denoising settings and rebased on master

Patrick Mours (pmoursnv) marked an inline comment as done.Feb 22 2021, 7:10 PM
This revision is now accepted and ready to land.Feb 22 2021, 7:30 PM