Fix: Fixes Bug with Multi Input Sockets picking wrong link if no link is selected
ClosedPublic
Actions

Authored by Fabian Schempp (fabian_schempp) on Feb 15 2021, 12:23 AM.

Details

Reviewers

Hans Goudey (HooglyBoogly)

Maniphest Tasks

T85966: Geometry Nodes: disconnecting socket disconnects a remote connection

Commits

rBa4f81c683896: Fix T85966: Wrong link picked when dragging multi-input socket

Summary

The socket drag opperator stores the index of the last picked socket into RNA in case the user mouse cursor leaves the link while dragging.

This id is not uniqe which is why sometimes a link from an other node withthe same id is picked.

This patch changes the way the last picked link is stored and stores a pointer to the link directly into SpaceNode_Runtime instead.

Video of the bug by @Pablo Vazquez (pablovazquez)

Diff Detail

Repository

rB Blender

Branch

fix_multi_input_socket_drag_bug (branched from master)

Build Status

Buildable 13206
Build 13206: arc lint + arc unit

Event Timeline

Fabian Schempp (fabian_schempp) requested review of this revision.Feb 15 2021, 12:23 AM

Fabian Schempp (fabian_schempp) created this revision.

Harbormaster completed remote builds in B12887: Diff 33981.Feb 15 2021, 12:23 AM

Applied clang format

Harbormaster completed remote builds in B12888: Diff 33982.Feb 15 2021, 12:26 AM

Fabian Schempp (fabian_schempp) edited the summary of this revision. (Show Details)Feb 15 2021, 12:31 AM

Fabian Schempp (fabian_schempp) edited the summary of this revision. (Show Details)Feb 15 2021, 12:35 AM

Fabian Schempp (fabian_schempp) added a subscriber: Pablo Vazquez (pablovazquez).

Fabian Schempp (fabian_schempp) retitled this revision from Fix: Fixes Bug with Multi Input Sockets picking wrong link if no link is picked. to Fix: Fixes Bug with Multi Input Sockets picking wrong link if no link is selected.Feb 15 2021, 12:37 AM

Fabian Schempp (fabian_schempp) edited the summary of this revision. (Show Details)Feb 15 2021, 12:52 AM

I agree. Sometimes i have the same problem. But forever reason not every time i grab a Node

Florian Kamenz (TimBrown) awarded a token.Feb 20 2021, 10:21 PM

I tested this a while ago and it fixed the problem for me. Thanks for the fix! It's also nice not to have to expose this as an operator property. However, I think this should be stored in wmOperator.customdata rather than the space runtime struct.

This revision now requires changes to proceed.Mar 2 2021, 4:42 PM