Page MenuHome
Differential D10430

[WIP] GPencil: Anti-aliasing quality.
Needs ReviewPublic
Actions

Authored by Jeroen Bakker (jbakker) on Feb 16 2021, 11:42 AM.
This revision needs review, but there are no reviewers specified.

Details

Reviewers
None
Maniphest Tasks
T85620: Port Temporal AntiAliasing to Grease Pencil
Summary

T85620: Port Temporal AntiAliasing to Grease Pencil

  • TAA is only done during image rendering.
  • In viewport only SMAA is used to reduce render artifacts when painting a stroke.

TODO

  • Integrate TAA in f12 rendering.
  • Add UI setting for Gpencil aa rendering.
  • Do some image diff tests.

Diff Detail

Repository
rB Blender
Branch
temp-gpencil-taa (branched from master)
Build Status
Buildable 14036
Build 14036: arc lint + arc unit

Event Timeline

Jeroen Bakker (jbakker) requested review of this revision.Feb 16 2021, 11:42 AM
Jeroen Bakker (jbakker) created this revision.
Harbormaster completed remote builds in B12914: Diff 34033.Feb 16 2021, 11:42 AM
Jeroen Bakker (jbakker) updated this revision to Diff 34039.Feb 16 2021, 1:51 PM

reverted part of the smaa

Harbormaster completed remote builds in B12918: Diff 34039.Feb 16 2021, 1:51 PM
Jeroen Bakker (jbakker) edited the summary of this revision. (Show Details)Feb 23 2021, 3:14 PM
Jeroen Bakker (jbakker) edited the summary of this revision. (Show Details)Feb 23 2021, 4:14 PM
Jeroen Bakker (jbakker) updated this revision to Diff 34324.Feb 23 2021, 4:43 PM

redo of the patch. where taa would (eventually) only be used during rendering.

Harbormaster completed remote builds in B13068: Diff 34324.Feb 23 2021, 4:43 PM
Jeroen Bakker (jbakker) edited the summary of this revision. (Show Details)Feb 23 2021, 4:46 PM
Jeroen Bakker (jbakker) updated this revision to Diff 34354.Feb 24 2021, 10:13 AM
  • Activate taa for rendering (incomplete)
  • TAA Reveal
Harbormaster completed remote builds in B13087: Diff 34354.Feb 24 2021, 10:13 AM
Jeroen Bakker (jbakker) updated this revision to Diff 34365.Feb 24 2021, 1:25 PM
  • GPencil: Initial TAA structure.
  • Activate taa for rendering (incomplete)
  • TAA Reveal
  • Copy history buffer (incomplete)
Harbormaster completed remote builds in B13093: Diff 34365.Feb 24 2021, 1:25 PM
Jeroen Bakker (jbakker) updated this revision to Diff 36126.Apr 13 2021, 3:17 PM
  • Fixed TAA when rendering.
Harbormaster completed remote builds in B14036: Diff 36126.Apr 13 2021, 3:17 PM

Revision Contents
Changeset List

PathSize
source/
blender/
draw/
2 lines
engines/
gpencil/
325 lines
34 lines
42 lines
24 lines
shaders/
21 lines
18 lines

Diff 36126

View Options

source/blender/draw/CMakeLists.txt

Loading...
View Options

source/blender/draw/engines/gpencil/gpencil_antialiasing.c

Loading...
View Options

source/blender/draw/engines/gpencil/gpencil_engine.h

Loading...
View Options

source/blender/draw/engines/gpencil/gpencil_engine.c

Loading...
View Options

source/blender/draw/engines/gpencil/gpencil_shader.c

Loading...
View Options

source/blender/draw/engines/gpencil/shaders/gpencil_taa_accum_frag.glsl

Loading...
View Options

source/blender/draw/engines/gpencil/shaders/gpencil_taa_resolve_frag.glsl

Loading...