Page MenuHome

Black/flake8/mypy looper and tests
AbandonedPublic

Authored by Anna Sirota (railla) on Feb 16 2021, 12:08 PM.

Details

Reviewers
None
Maniphest Tasks
T85646: Decoupling looper
Summary

Goal

Minimising cosmetic differences between standalone looper and DevFund's looper.

What it does

  • mypy and flake8 upgraded to take care of issues such as https://github.com/PyCQA/pyflakes/issues/475;
  • applies black and flake8 fixes to looper modules and all DevFund's tests;
  • copies over most of the mypy-related annotations from the standalone looper into DevFund's:

    standalone looper's usage of typing is preferred, e.g. from typing import ... vs import typing;
  • contents of looper/tests/__init__.py moved to looper/tests/base.py, to keep it consistent with the standalone version.

Branch

blackify-mypy-looper

Sanity check for accidental changes:

  • No changes to models:
$ python manage.py makemigrations --dry-run
No changes detected
  • No migrations:
$ python manage.py migrate --plan
Planned operations:
  No planned migration operations.
  • Tests are passing
  • It's possible to go through checkout locally

Diff Detail

Event Timeline

Anna Sirota (railla) requested review of this revision.Feb 16 2021, 12:08 PM
Anna Sirota (railla) created this revision.
Anna Sirota (railla) edited the summary of this revision. (Show Details)
Anna Sirota (railla) edited the summary of this revision. (Show Details)
Anna Sirota (railla) edited the summary of this revision. (Show Details)Feb 16 2021, 12:13 PM
Anna Sirota (railla) edited the summary of this revision. (Show Details)Feb 16 2021, 12:16 PM
Anna Sirota (railla) retitled this revision from Black/flake8 looper and tests to Black/flake8/mypy looper and tests.
Anna Sirota (railla) edited the summary of this revision. (Show Details)
Anna Sirota (railla) edited the summary of this revision. (Show Details)Feb 16 2021, 12:20 PM
Anna Sirota (railla) edited the summary of this revision. (Show Details)
  • apply black to looper/signals.py
  • Revert "Move a BID-dependant signal outside looper"

Will not be merged in its current state.