Page MenuHome
Differential D10432

Geometry Nodes: Realize instances before passing geometry to mesh modifier.
ClosedPublic
Actions

Authored by Jacques Lucke (JacquesLucke) on Feb 16 2021, 12:42 PM.

Details

Reviewers
Hans Goudey (HooglyBoogly)
Commits
rB96da8e9ca302: Geometry Nodes: realize instances before passing geometry to constructive mesh…
Summary

This is a first step for T85281: Support piping legacy modifiers with the geometry nodes modifiers.

What's missing is that point clouds are not converted to mesh vertices yet. I'd like to add that in a separate patch.

This patch works by making instances real when there is a modifier that does not know what a geometry set is, i.e. it cannot work with instances directly.
Making instances real requires more memory and more computation time, so it is only done on demand.
If there is no other modifier after the Geometry Nodes modifier, instances will remain instances for rendering.

Note, making instances real can result in loosing some information that we do not support in geometry nodes yet. That includes some special builtin attributes like material indices, bevel weights, ...

Diff Detail

Repository
rB Blender

Event Timeline

Jacques Lucke (JacquesLucke) requested review of this revision.Feb 16 2021, 12:42 PM
Jacques Lucke (JacquesLucke) created this revision.
Harbormaster completed remote builds in B12915: Diff 34035.Feb 16 2021, 12:42 PM
Jacques Lucke (JacquesLucke) edited the summary of this revision. (Show Details)Feb 16 2021, 12:49 PM
Jacques Lucke (JacquesLucke) added a reviewer: Hans Goudey (HooglyBoogly).
kursad k (kursadk) awarded a token.Feb 16 2021, 7:40 PM
Hans Goudey (HooglyBoogly) accepted this revision.Feb 16 2021, 11:04 PM

The code makes sense and it worked in my testing.

This revision is now accepted and ready to land.Feb 16 2021, 11:04 PM
Closed by commit rB96da8e9ca302: Geometry Nodes: realize instances before passing geometry to constructive mesh… (authored by Jacques Lucke (JacquesLucke)). · Explain WhyFeb 17 2021, 12:28 PM
This revision was automatically updated to reflect the committed changes.
Jacques Lucke (JacquesLucke) added a commit: rB96da8e9ca302: Geometry Nodes: realize instances before passing geometry to constructive mesh….
Damian (damian) awarded a token.Feb 17 2021, 4:36 PM
Damian (damian) added a subscriber: Damian (damian).EditedFeb 17 2021, 4:44 PM

This is my top 10 awaited feature.♥
Although, for the procedural trees' and ivys' creation, it'll be super-handy to have access to Radius.X/Radius.Y attribute, for the Skin modifier.



Geometry nodes ivy 2.blend1011 KBDownload

Hans Goudey (HooglyBoogly) added a comment.EditedFeb 18 2021, 5:00 AM

Hey @Damian (damian), thanks for the comment, but please avoid making feature requests in code review here. You can probably imagine how messy things would become around here if we allowed that.

rightclickselect.com is the place for feature requests, for more discussion there's always blender.chat too. Thanks.

Damian (damian) added a comment.Feb 19 2021, 1:38 AM
In D10432#263453, @Hans Goudey (HooglyBoogly) wrote:

Hey @Damian (damian), thanks for the comment, but please avoid making feature requests in code review here. You can probably imagine how messy things would become around here if we allowed that.

rightclickselect.com is the place for feature requests, for more discussion there's always blender.chat too. Thanks.

My apologies. Will try to avoid that in future.
I meant this more like a reporting that not every modifier works perfectly on top of the Geometry nodes.
I saw people are sharing their setups here on...

Revision Contents
Changeset List

PathSize
source/
blender/
blenkernel/
intern/
36 lines

Diff 34081

View Options

source/blender/blenkernel/intern/DerivedMesh.cc

Loading...