Page MenuHome
Differential D10435

Move requires_status to looper.decorators and type-annotate it
ClosedPublic
Actions

Authored by Anna Sirota (railla) on Feb 16 2021, 3:10 PM.

Details

Reviewers
Sybren A. Stüvel (sybren)
Maniphest Tasks
T85646: Decoupling looper
Summary

Moves the requires_status decorator from looper.models to looper.decorators and annotates it.

Diff Detail

Event Timeline

Anna Sirota (railla) requested review of this revision.Feb 16 2021, 3:10 PM
Anna Sirota (railla) created this revision.
Anna Sirota (railla) edited the summary of this revision. (Show Details)Feb 16 2021, 3:12 PM
Sybren A. Stüvel (sybren) accepted this revision.Feb 16 2021, 3:38 PM
Sybren A. Stüvel (sybren) added a subscriber: Sybren A. Stüvel (sybren).
Sybren A. Stüvel (sybren) added inline comments.
looper/decorators.py
7

Since everything in Python is an object, what's your reason to use object here instead of Any?

This revision is now accepted and ready to land.Feb 16 2021, 3:38 PM
Anna Sirota (railla) updated this revision to Diff 34051.Feb 16 2021, 3:47 PM
  • Consistent use of Any
Anna Sirota (railla) marked an inline comment as done.Feb 16 2021, 3:47 PM
Anna Sirota (railla) mentioned this in rBDFb78468a0da19: Move requires_status to looper.decorators and type-annotate it D10435.Feb 16 2021, 3:48 PM
Anna Sirota (railla) closed this revision.Feb 16 2021, 4:01 PM

Landed in b78468a0da19

Anna Sirota (railla) mentioned this in T85646: Decoupling looper.Feb 16 2021, 5:34 PM
Anna Sirota (railla) added a task: T85646: Decoupling looper.Mar 9 2021, 2:24 PM

Revision Contents
Changeset List

PathSize
looper/
32 lines
30 lines

Diff 34051

View Options

looper/decorators.py

Loading...
View Options

looper/models.py

Loading...