Move signals that aren't specific to looper out of `looper.signals`
ClosedPublic
Actions

Authored by Anna Sirota (railla) on Feb 16 2021, 4:09 PM.

Details

Reviewers

Sybren A. Stüvel (sybren)

Maniphest Tasks

T85646: Decoupling looper

Summary

The reason for moving set_customer_fullname is that it depends on blender_id_oauth_client, which is not a dependency of the standalone looper.
The reason for moving create_customer is that in other projects the same signal might be implemented differently, e.g. Studio will be prefilling Customer based on more of User fields, because structure of the User model is different there.

Diff Detail

Repository: rBDF Blender Dev Fund

Event Timeline

Anna Sirota (railla) requested review of this revision.Feb 16 2021, 4:09 PM

Anna Sirota (railla) created this revision.

Anna Sirota (railla) retitled this revision from Move a Blender ID-dependent signal out of `looper.signals` to [WIP] Move a Blender ID-dependent signal out of `looper.signals`.Feb 16 2021, 4:18 PM

Anna Sirota (railla) updated this revision to Diff 34054.Feb 16 2021, 4:28 PM

Anna Sirota (railla) retitled this revision from [WIP] Move a Blender ID-dependent signal out of `looper.signals` to Move signals that aren't specific to looper out of `looper.signals`.

Anna Sirota (railla) edited the summary of this revision. (Show Details)

Anna Sirota (railla) added a reviewer: Sybren A. Stüvel (sybren).Feb 16 2021, 4:48 PM

Anna Sirota (railla) edited the summary of this revision. (Show Details)

Anna Sirota (railla) mentioned this in T85646: Decoupling looper.Feb 16 2021, 5:34 PM

LGTM

This revision is now accepted and ready to land.Feb 18 2021, 11:54 AM

Anna Sirota (railla) mentioned this in rBDFbf6ca6ea8242: Move signals that aren't specific to looper out of D10437.Feb 18 2021, 12:02 PM

Landed in bf6ca6ea824299f034af4a7adce3929400f082ef

Anna Sirota (railla) added a task: T85646: Decoupling looper.Mar 9 2021, 2:24 PM