Fix T84659: Walk navigation hangs for tablet input.
AbandonedPublic
Actions

Authored by Nicholas Rishel (nicholas_rishel) on Feb 17 2021, 7:16 AM.

Details

Reviewers

Campbell Barton (campbellbarton)
Brecht Van Lommel (brecht)

Maniphest Tasks

T84659: Walk navigation stylus issues in 2.92 - no mouse input until alt tabbing (regression)

Summary

The walk operator centers the mouse to the region when it starts and
waits for a corresponding mouse move event, which may never occur while
a tablet is active and constraining cursor movement. With this change,
when mouse movement is from an absolute position device the operator
does not wait for a centering cursor move before running.

Diff Detail

Repository

rB Blender

Branch

blender-v2.92-release

Build Status

Buildable 12938
Build 12938: arc lint + arc unit

Event Timeline

Nicholas Rishel (nicholas_rishel) requested review of this revision.Feb 17 2021, 7:16 AM

Nicholas Rishel (nicholas_rishel) created this revision.

Harbormaster completed remote builds in B12938: Diff 34073.Feb 17 2021, 7:16 AM

Tested with Windows 10 Wintab and Windows Ink.

Nicholas Rishel (nicholas_rishel) added a task: T84659: Walk navigation stylus issues in 2.92 - no mouse input until alt tabbing (regression).Feb 17 2021, 7:19 AM

I've tested the patch and this resolves the issue for me. When the mouse is moving while entering walk navigation it now follows the movement immediately, while previously it was stuck at the center of the screen.

Brecht Van Lommel (brecht) accepted this revision.Feb 22 2021, 7:31 PM

This revision is now accepted and ready to land.Feb 22 2021, 7:31 PM

Nicholas Rishel (nicholas_rishel) planned changes to this revision.Feb 22 2021, 7:33 PM

Abandoned for issues pointed out in T84659.

Nicholas Rishel (nicholas_rishel) mentioned this in T85874: Fix remaining tablet regression issues.Feb 23 2021, 9:36 PM