Differential D10448

Principled BSDF: Fix specular color for black base color
ClosedPublic
Actions

Authored by Pascal Schön (VanCantus) on Feb 17 2021, 1:30 PM.

Tags

Subscribers

None

Details

Reviewers

Brecht Van Lommel (brecht)

Commits

rCf36d1e055752: Fix Principled BSDF specular color for black base color
rB277b4f4b9377: Fix Principled BSDF specular color for black base color

Summary

Specular color is set to black instead of white inside the Principled BSDF when the base color is set to fully black. This is contradictory to the sample code of the Disney BRDF in BRDF Explorer (https://github.com/wdas/brdf/blob/main/src/brdfs/disney.brdf).

This patch aligns both implementations.

Diff Detail

Repository: rB Blender

Event Timeline

Pascal Schön (VanCantus) requested review of this revision.Feb 17 2021, 1:30 PM

Pascal Schön (VanCantus) created this revision.

Thanks! I'll fix the Eevee implementation as well in the commit.

This revision is now accepted and ready to land.Feb 22 2021, 6:33 PM

Closed by commit rB277b4f4b9377: Fix Principled BSDF specular color for black base color (authored by Pascal Schön (VanCantus), committed by Brecht Van Lommel (brecht)). · Explain WhyFeb 22 2021, 6:34 PM

This revision was automatically updated to reflect the committed changes.

Brecht Van Lommel (brecht) added a commit: rB277b4f4b9377: Fix Principled BSDF specular color for black base color.

Stefan Werner (swerner) added a commit: rCf36d1e055752: Fix Principled BSDF specular color for black base color.Jun 2 2021, 9:17 PM

Revision Contents
Changeset List

Path

Size

intern/

cycles/

kernel/

shaders/

node_principled_bsdf.osl

2 lines

svm/

2 lines

Diff 34084

intern/cycles/kernel/shaders/node_principled_bsdf.osl

Loading...

intern/cycles/kernel/svm/svm_closure.h

Loading...