Fix for T85517
Bug: Couldn't type space while holding down the shift key in text spaces (e.g. when saving a file, changing the name of object).
Changes: Removing the key combination of Shift + space in WM_event_is_ime_switch method.
Details
Details
- Reviewers
Harley Acheson (harley) Bastien Montagne (mont29) - Maniphest Tasks
- T85517: Blender File View - can't type space while holding shift key.
- Commits
- rB60a0928f3559: Fix T85517: Cannot type Space while holding Shift key in text-field like spaces.
rB6abf63f463cf: Fix T85517: Cannot type Space while holding Shift key in text-field like spaces.
Diff Detail
Diff Detail
- Repository
- rB Blender
- Branch
- space_fix (branched from master)
- Build Status
Buildable 12954 Build 12954: arc lint + arc unit
Event Timeline
Comment Actions
Yes, that is actually all that is required, and I tested it like that a couple days ago.
For other reviewers: This little function, WM_event_is_ime_switch(), does not start/stop/help/hinder the usage of IME, and is not even called while IME composing.
It is just there for users with multiple languages installed, who might hit a hotkey to switch languages or IMEs before starting to write. This has been ctrl-space and sometimes alt-space in the past. I can't think any that ever used shift-space. But if this were the case then this little function would keep the user from getting an extra "space" in their input at that time. So just a convenience.
Windows now uses oskey-space, and because of the way this key is processed it never makes it to this function (or to blender at all) anyway. It might be possible to remove this entire function now, but I'm not certain enough of that, so I think we should keep it for now. For interest, here is what happens when I press Windows-space:
Why this issue is coming up now though, is that we now allow any language input, regardless of what output translation language is selected. So this function is called more often now.
Comment Actions
yes this makes sense to me indeed, would also expect Shift Space to be handled as a regular character input when in text editing context...