Page MenuHome
Differential D10453

VSE: Overlay options exposed in both View menu and in Overlay pop over
ClosedPublic
Actions

Authored by Peter Fog (tintwotin) on Feb 17 2021, 6:14 PM.

Details

Reviewers
Richard Antalik (ISS)
Campbell Barton (campbellbarton)
Commits
rB94cd52a16262: VSE: Fix duplicate menu entries
Summary

Overlay options exposed in both View menu and in Overlay pop over:

This is a regression caused by this patch: https://developer.blender.org/rBf448ff2afe7a77279fe96282447912a6f7773ed3

This patch removes the doubles in the View menu. If possible, this fix would be good to have committed to 2.92 too.

Diff Detail

Event Timeline

Peter Fog (tintwotin) requested review of this revision.Feb 17 2021, 6:14 PM
Peter Fog (tintwotin) created this revision.
Peter Fog (tintwotin) edited the summary of this revision. (Show Details)Feb 17 2021, 8:23 PM
Peter Fog (tintwotin) added a project: VFX & Video.Feb 17 2021, 11:51 PM
Richard Antalik (ISS) added inline comments.Feb 18 2021, 10:07 AM
release/scripts/startup/bl_ui/space_sequencer.py
419–420

Just checked patch, and this shouldn't have been removed in first place. So I should commit without this change

Peter Fog (tintwotin) added inline comments.Feb 19 2021, 6:16 AM
release/scripts/startup/bl_ui/space_sequencer.py
419–420

Currently, that is also in there twice: https://developer.blender.org/diffusion/B/browse/master/?grep=Show+Separate+Color+Channels And therefore needs to be removed as in the patch.

Richard Antalik (ISS) accepted this revision.Feb 19 2021, 11:19 AM
Richard Antalik (ISS) added inline comments.
release/scripts/startup/bl_ui/space_sequencer.py
419–420

Ah right I see now, I checked this with patch applied.

This revision is now accepted and ready to land.Feb 19 2021, 11:19 AM
Campbell Barton (campbellbarton) accepted this revision.Feb 19 2021, 11:23 AM
Closed by commit rB94cd52a16262: VSE: Fix duplicate menu entries (authored by Peter Fog (tintwotin), committed by Richard Antalik (ISS)). · Explain WhyFeb 19 2021, 1:49 PM
This revision was automatically updated to reflect the committed changes.
Richard Antalik (ISS) added a commit: rB94cd52a16262: VSE: Fix duplicate menu entries.

Revision Contents
Changeset List

PathSize
release/
scripts/
startup/
bl_ui/
11 lines

Diff 34104

View Options

release/scripts/startup/bl_ui/space_sequencer.py

Loading...