Paths

Table of Contentst

Differential D10462

Geometry Nodes: Store available attribute names in node ui storage.
ClosedPublic
Actions

Authored by Jacques Lucke (JacquesLucke) on Feb 18 2021, 1:04 PM.

Tags

None

Subscribers

None

Details

Reviewers

Hans Goudey (HooglyBoogly)

Maniphest Tasks

T85657: Remember the attributes that are available during the nodetree evaluation for attribute search dropdown

Commits

rBc0b2c75c441d: Geometry Nodes: store available attribute names in node ui storage

Summary

There are more sophisticated ways to create a list of available attributes, but this should be a good starting point for an initial implementation.

Diff Detail

Repository: rB Blender

Event Timeline

Jacques Lucke (JacquesLucke) requested review of this revision.Feb 18 2021, 1:04 PM

Jacques Lucke (JacquesLucke) created this revision.

Harbormaster completed remote builds in B12969: Diff 34122.Feb 18 2021, 1:04 PM

Jacques Lucke (JacquesLucke) added a reviewer: Hans Goudey (HooglyBoogly).Feb 18 2021, 1:06 PM

cleanup

Harbormaster completed remote builds in B12998: Diff 34167.Feb 19 2021, 12:33 PM

Jacques Lucke (JacquesLucke) retitled this revision from Geometry Nodes: Store available attribute names in node ui storage (WIP). to Geometry Nodes: Store available attribute names in node ui storage..Feb 19 2021, 12:36 PM

Jacques Lucke (JacquesLucke) edited the summary of this revision. (Show Details)

Hans Goudey (HooglyBoogly) added a child revision: D10519: Geometry Nodes: Attribute Search Buttons.Feb 24 2021, 12:35 AM

This makes sense as a first step, one thought inline though.

source/blender/blenkernel/BKE_node_ui_storage.hh
100	Might it make sense to support adding multiple attributes at the same time? Since in practice, this will just union one or two sets/maps with each other. The argument would then be a reference to the map of attribute data (or a set at first, if we still want to just store the names as a first step). Theoretically this could then avoid copying completely, for the attributes from the first component.

Jacques Lucke (JacquesLucke) added inline comments.Feb 24 2021, 11:53 AM

source/blender/blenkernel/BKE_node_ui_storage.hh
100	Hmm, could be useful, but I wouldn't want to do it right now. I think passing in the attribute names separate might be even more efficient than constructing a separate set. Also note that in the future we might pass more information than just the attribute name (domain, type, ...).

Jacques Lucke (JacquesLucke) mentioned this in D10519: Geometry Nodes: Attribute Search Buttons.Feb 24 2021, 12:01 PM

use attribute_foreach instead of attribute_names

Harbormaster completed remote builds in B13090: Diff 34362.Feb 24 2021, 12:09 PM

Hans Goudey (HooglyBoogly) accepted this revision.Feb 24 2021, 3:16 PM

Hans Goudey (HooglyBoogly) added inline comments.

source/blender/blenkernel/BKE_node_ui_storage.hh
100	Okay, with this version and `foreach_attribute` there is no temporary set built anyway, so this makes sense!

This revision is now accepted and ready to land.Feb 24 2021, 3:16 PM

Closed by commit rBc0b2c75c441d: Geometry Nodes: store available attribute names in node ui storage (authored by Jacques Lucke (JacquesLucke)). · Explain WhyFeb 24 2021, 4:00 PM

This revision was automatically updated to reflect the committed changes.

Jacques Lucke (JacquesLucke) added a commit: rBc0b2c75c441d: Geometry Nodes: store available attribute names in node ui storage.

Revision Contents
Changeset List

Path

Size

source/

blender/

blenkernel/

BKE_node_ui_storage.hh

7 lines

intern/

node_ui_storage.cc

9 lines

modifiers/

intern/

30 lines

Diff 34371

source/blender/blenkernel/BKE_node_ui_storage.hh

Loading...

source/blender/blenkernel/intern/node_ui_storage.cc

Loading...

source/blender/modifiers/intern/MOD_nodes.cc

Loading...