Page MenuHome
Differential D10463

Fix T85762: Crash when opening 2.83 VSE file
ClosedPublic
Actions

Authored by Richard Antalik (ISS) on Feb 18 2021, 2:06 PM.

Details

Reviewers
Campbell Barton (campbellbarton)
Maniphest Tasks
T85762: 2.92 crashes when opening 2.83 files containing VSE strips created using Python API
Commits
rBc297bef9aff5: Fix T85762: Crash when opening 2.83 VSE file
Summary

Crash happened in versioning code on NULL dereference in function
seq_convert_transform_crop() for Strip crop and transform
fields.

Strips created after rB1fd7b380f4cf were assumed to have crop and
transform always initialized, but this wasn't the case. This has been
fixed in 2.90, but not in versioning code.

Initialize these fields if they are not initialized already.

Diff Detail

Repository
rB Blender

Event Timeline

Richard Antalik (ISS) requested review of this revision.Feb 18 2021, 2:06 PM
Richard Antalik (ISS) created this revision.
Harbormaster completed remote builds in B12971: Diff 34124.Feb 18 2021, 2:06 PM
Campbell Barton (campbellbarton) accepted this revision.Feb 18 2021, 3:34 PM
This revision is now accepted and ready to land.Feb 18 2021, 3:34 PM
Closed by commit rBc297bef9aff5: Fix T85762: Crash when opening 2.83 VSE file (authored by Richard Antalik (ISS)). · Explain WhyFeb 18 2021, 7:02 PM
This revision was automatically updated to reflect the committed changes.
Richard Antalik (ISS) added a commit: rBc297bef9aff5: Fix T85762: Crash when opening 2.83 VSE file.

Revision Contents
Changeset List

PathSize
source/
blender/
blenloader/
intern/
7 lines

Diff 34141

View Options

source/blender/blenloader/intern/versioning_290.c

Loading...