Page MenuHome
Differential D10465

Fix T85753: Default UVs for Icosphere are flipped horizontally
ClosedPublic
Actions

Authored by Philipp Oeser (lichtwerk) on Feb 18 2021, 4:35 PM.

Details

Reviewers
Campbell Barton (campbellbarton)
Maniphest Tasks
T85753: Default UVs for Icosphere are flipped horizontally
Commits
rB5f8b6a9c0eb3: Fix T85753: Default UVs for Icosphere are flipped horizontally
Summary

These were flipped since their introduction in rBa070a5befa11.

Before

After

Diff Detail

Repository
rB Blender
Branch
T85753 (branched from master)
Build Status
Buildable 12976
Build 12976: arc lint + arc unit

Event Timeline

Philipp Oeser (lichtwerk) requested review of this revision.Feb 18 2021, 4:35 PM
Philipp Oeser (lichtwerk) created this revision.
Harbormaster completed remote builds in B12976: Diff 34135.Feb 18 2021, 4:35 PM
Philipp Oeser (lichtwerk) edited the summary of this revision. (Show Details)Feb 18 2021, 4:36 PM
Philipp Oeser (lichtwerk) added a reviewer: Modeling.
Philipp Oeser (lichtwerk) added a project: Modeling.
Bastien Montagne (mont29) added a subscriber: Bastien Montagne (mont29).Feb 18 2021, 5:16 PM

Please DO NOT add projects as reviewers... This spamming way too many people.

Bastien Montagne (mont29) removed a reviewer: Modeling.Feb 18 2021, 5:16 PM
Philipp Oeser (lichtwerk) added a comment.Feb 18 2021, 5:21 PM
In D10465#263631, @Bastien Montagne (mont29) wrote:

Please DO NOT add projects as reviewers... This spamming way too many people.

Sorry.

Do we have a common guideline on this?
Animation & Rigging seems to do exactly that : https://wiki.blender.org/wiki/Modules/Animation-Rigging/Code_Review

Hans Goudey (HooglyBoogly) added a subscriber: Hans Goudey (HooglyBoogly).Feb 18 2021, 5:28 PM

The UI module does that too, so it's not a policy everywhere. As far as I know you can turn off the alerts when someone adds a project you're a member of as a reviewer.

Philipp Oeser (lichtwerk) added a project: Restricted Project.Feb 22 2021, 9:07 AM
Campbell Barton (campbellbarton) accepted this revision.Feb 22 2021, 10:36 AM
This revision is now accepted and ready to land.Feb 22 2021, 10:36 AM
Closed by commit rB5f8b6a9c0eb3: Fix T85753: Default UVs for Icosphere are flipped horizontally (authored by Philipp Oeser (lichtwerk)). · Explain WhyFeb 22 2021, 6:50 PM
This revision was automatically updated to reflect the committed changes.
Philipp Oeser (lichtwerk) added a commit: rB5f8b6a9c0eb3: Fix T85753: Default UVs for Icosphere are flipped horizontally.

Revision Contents
Changeset List

PathSize
source/
blender/
bmesh/
operators/
30 lines

Diff 34135

View Options

source/blender/bmesh/operators/bmo_primitive.c

Loading...