Differential D10466

Fix T85763: Add a check in align rotation to vector node
ClosedPublic
Actions

Authored by Wannes Malfait (Wannes) on Feb 18 2021, 6:04 PM.

Details

Reviewers

Jacques Lucke (JacquesLucke)

Maniphest Tasks

T85763: Geometry Nodes: Align rotation to vector node doesn't flip rotation when vector is multiplied by -1

Commits

rB359d0029fe76: Fix T85763: Align Rotation to Vector node fails for collinear vectors

Summary

If the axes are aligned in auto pivot mode then the rotation axis would be (0,0,0).
We now fall back to the x axis in this case. If that fails, we fall back to the y axis.

Old:

New:

Diff Detail

Repository: rB Blender

Event Timeline

Wannes Malfait (Wannes) requested review of this revision.Feb 18 2021, 6:04 PM

Wannes Malfait (Wannes) created this revision.

Harbormaster completed remote builds in B12979: Diff 34139.Feb 18 2021, 6:04 PM

Wannes Malfait (Wannes) edited the summary of this revision. (Show Details)Feb 18 2021, 6:10 PM

Wannes Malfait (Wannes) added a project: Geometry Nodes.

Wannes Malfait (Wannes) added a task: T85763: Geometry Nodes: Align rotation to vector node doesn't flip rotation when vector is multiplied by -1.Feb 18 2021, 7:01 PM

Looks good, thanks!

This revision is now accepted and ready to land.Feb 19 2021, 11:35 AM

Closed by commit rB359d0029fe76: Fix T85763: Align Rotation to Vector node fails for collinear vectors (authored by Wannes Malfait (Wannes), committed by Jacques Lucke (JacquesLucke)). · Explain WhyFeb 19 2021, 11:38 AM

This revision was automatically updated to reflect the committed changes.

Jacques Lucke (JacquesLucke) added a commit: rB359d0029fe76: Fix T85763: Align Rotation to Vector node fails for collinear vectors.

Revision Contents
Changeset List

Path

Size

source/

blender/

nodes/

geometry/

nodes/

node_geo_align_rotation_to_vector.cc

10 lines

Diff 34165

View Options

source/blender/nodes/geometry/nodes/node_geo_align_rotation_to_vector.cc

Fix T85763: Add a check in align rotation to vector nodeClosedPublicActions