Differential D10524

Send an email when account deletion request is received
ClosedPublic
Actions

Authored by Anna Sirota (railla) on Feb 24 2021, 6:38 PM.

Details

Reviewers

Sybren A. Stüvel (sybren)

Maniphest Tasks

T85153: Send a confirmation email when deletion is requested

Summary

Goal

As a user I'd like to receive an email confirming that my request to delete account had been received.

What it does

This patch adds an email template (HTML and plaintext), used when someone requests account deletion, to send an email reiterating the same things that account deletion form already states.

HTML:

Plaintext:

Hi Veniamin von Testhoff!

You are receiving this message because your have requested deletion of your Blender ID account.
Your account have been deactivated and you've been logged out of Blender ID.
Data linked to the account will not be deleted for another 2 weeks.

**Important**: you will not be able to create a new account
with the same email address, until this process is completed.

Note that some of the data, such as financial records and public content,
such as comments on Blender Cloud, will be anonymized but not deleted.

We are sad to see you go!

Kind regards,

The Blender Web Team

Diff Detail

Repository: rBID Blender ID

Event Timeline

Anna Sirota (railla) requested review of this revision.Feb 24 2021, 6:38 PM

Anna Sirota (railla) created this revision.

Anna Sirota (railla) added a task: T85153: Send a confirmation email when deletion is requested.

Anna Sirota (railla) added a reviewer: Sybren A. Stüvel (sybren).Feb 24 2021, 6:41 PM

Wording of a log message changed

Unused parameters removed; test added

because your have

you have

Your account have been

has been

you've been logged out

Previous sentences didn't use conjucations. Either use them or don't, but don't mix styles.

Important: you will not be able to create a new account with the same email address, until this process is completed.

The comma should be removed, as that serves to separate the main clause from the subclause; in such cases the main clause should be true by itself, which isn't the case here.

I feel the plaintext looks a bit messy, given that there are so many different lengths at which it's wrapped. I feel that it should be wrapped to be at most 76 characters (my preference) or not be wrapped at all.

bid_main/email.py
129	Not sure if we should be logging the email address of a user who chose to be forgotten.
192	It's probably better to start the subject with "Blender ID", like "Blender ID account deletion". That way the first words identify what it's about.

This revision now requires changes to proceed.Feb 25 2021, 12:52 PM

Do not use the email in another logging message
Wording of the subject changed
Typos and stylistic errors in the plaintext template corrected, wrapping removed
Typos and stylistic errors in the HTML template corrected
Nonsensical comma removed from the form
Do not log the email

Anna Sirota (railla) marked 2 inline comments as done.Feb 25 2021, 1:10 PM

Sybren A. Stüvel (sybren) accepted this revision.Feb 25 2021, 5:49 PM

This revision is now accepted and ready to land.Feb 25 2021, 5:49 PM

Landed in eed47a2c77a2f7d1edaba388f47201cb4e06cd34