Page MenuHome

UI: Add an option to search buttons to allow any string input
ClosedPublic

Authored by Hans Goudey (HooglyBoogly) on Feb 24 2021, 9:14 PM.

Details

Summary

For geometry nodes we will use search buttons to display a list of
attributes available the last time the node tree was executed (D10519).
Because this list is just a hint, we need to be able to enter any string,
not just strings from the search items.

This patch adds a boolean option to string buttons to enable this.
The change is quite simple, changes to behavior are only required in
two places. The type-specific button struct changes help a lot here.

Diff Detail

Repository
rB Blender

Event Timeline

Hans Goudey (HooglyBoogly) requested review of this revision.Feb 24 2021, 9:14 PM
Hans Goudey (HooglyBoogly) created this revision.
  • Change order of assert and cast
  • Fix order of apply and all strings valid check
  • Fix clang format issue

all_strings_valid is a bit cryptic to me. Could be results_are_suggestions or so? Besides that, seems reasonable.

Thanks for looking at this. results_are_suggestions sounds fine to me. I'll switch to that.

  • Merge branch 'master' into search-button-allow-all
  • Rename boolean to results_are_suggestions
This revision is now accepted and ready to land.Mar 2 2021, 7:29 PM
This revision was automatically updated to reflect the committed changes.