Page MenuHome

VSE: Add bold and italic
ClosedPublic

Authored by Peter Fog (tintwotin) on Feb 26 2021, 9:40 AM.

Details

Summary

This patch will add bold and italic to text strips.

REMOVED FROM THIS PATCH AND SPLIT INTO: D10571
In addition to this there are a some minor tweaks:

  • The defaults has been changed along these lines: D7768
  • Center the text vertically.
  • Make font larger(project is not in SD anymore).
  • Set wrap to 1 - wrapping at screen edge - as default.
  • Make box transparent(looks better).
  • Allow shadows on texts when box.
  • Make margin use more sane values.
  • Add decorate to margin. This will fix bad aligning of buttons and expose the fact that this value can be animated.
  • Change text shadow to lower right direction in alignment with the box shadow.

New default text settings:

Before:

Diff Detail

Event Timeline

Peter Fog (tintwotin) requested review of this revision.Feb 26 2021, 9:40 AM
Peter Fog (tintwotin) created this revision.
Peter Fog (tintwotin) edited the summary of this revision. (Show Details)Feb 26 2021, 9:53 AM

I would advise to split this patch into adding bold and italic feature and adjusting defaults.

Don't see any problem with bold/italic implementation, but with de faults I would like another opinion, I don't feel confident evaluating aesthetic stuff. Overall it seems better, but these changes are quite arbitrary to me.
Box margin works exactly same though, you have just changed range from 0-1 to 0-100 with different effective step size.

Ok. Here is the Bold & Italic patch alone: P2002, but let me remind you that I presented new text presets almost a year ago. First as subtitles according to BBC standards D7714 and then as centered D7768 and now incorporated in this patch. And during all of this time no one else than you and I have been engaged in the discussion of the default settings of text strips, so I think it is a bit optimistic that yet another patch, will make people want to discuss these things.

The trouble with the current defaults are ex. that the text size is that small it'll only fit for SD resolution(which is not the current default resolution), it is placed at the very bottom, where no one will need it(not as subtitles nor title), and you'll miss it if you have the preview zoomed just a bit in, there is no text wrapping, who would need adding text outside of the screen as a default? The margin is moving in odd increments, and why should it be in fractions, it's a magic number no matter what. Also the position ranges are currently way too limited(0->1) to do rolling credits, or have large text animated in or out of the screen.

With a position range of -10 -> +10(not added in this patch) something like this can be done:

Peter Fog (tintwotin) edited the summary of this revision. (Show Details)

Tweaks split into: D10571

Peter Fog (tintwotin) edited the summary of this revision. (Show Details)Mar 1 2021, 7:28 PM
Peter Fog (tintwotin) retitled this revision from VSE: Add bold, italic and text strip tweaks to VSE: Add bold and italic.Mar 1 2021, 10:07 PM
Richard Antalik (ISS) requested changes to this revision.Mar 2 2021, 4:31 PM
Richard Antalik (ISS) added inline comments.
release/scripts/startup/bl_ui/space_sequencer.py
1296

This is also unrelated change.

source/blender/sequencer/intern/effects.c
4024–4028

These are unrelated changes still

This revision now requires changes to proceed.Mar 2 2021, 4:31 PM

Updated according to comments.

This revision is now accepted and ready to land.Mar 18 2021, 4:48 PM