Paths

Table of Contentst

Differential D10547

Fix T84658: Anisotropic BSDF - most modes not using Screen Space Reflection
ClosedPublic
Actions

Authored by Philipp Oeser (lichtwerk) on Feb 26 2021, 5:00 PM.

Tags

Subscribers

None

Details

Reviewers

Clément Foucault (fclem)

Maniphest Tasks

T84658: Anisotropic BSDF - most modes not using Screen Space Reflection

Commits

rB71ed6f32d2e3: Fix T84658: Anisotropic BSDF - most modes not using Screen Space

Summary

Anisotropic is not really supported in Eevee, but since code looks like
it is just intended to make it behave like glossy, it should function
like it too.

Seems like the internal calling from node_bsdf_glossy from
node_bsdf_anisotropic has swapped arguments.
Also: ssr_id is available for SH_NODE_BSDF_ANISOTROPIC as well (see
ntree_tag_bsdf_cb), so why not use it?

Diff Detail

Repository

Branch

T84658 (branched from master)

Build Status

Buildable 13158
Build 13158: arc lint + arc unit

Event Timeline

Philipp Oeser (lichtwerk) requested review of this revision.Feb 26 2021, 5:00 PM

Philipp Oeser (lichtwerk) created this revision.

Harbormaster completed remote builds in B13131: Diff 34462.Feb 26 2021, 5:00 PM

Philipp Oeser (lichtwerk) added a project: EEVEE & Viewport.Feb 26 2021, 5:02 PM

Clément Foucault (fclem) requested changes to this revision.Feb 27 2021, 9:09 PM

Clément Foucault (fclem) added inline comments.

source/blender/gpu/shaders/material/gpu_shader_material_anisotropic.glsl
8–9	Make that a `const`
9	Make that a `const`
16	this stub needs to be updated too.

This revision now requires changes to proceed.Feb 27 2021, 9:09 PM

make params const and update stub

Harbormaster completed remote builds in B13158: Diff 34509.Feb 28 2021, 9:07 PM

thx checking.
reg. const : might be worth a cleanup commit (seems it is not used consistent across files), but that is for another time.

Yes the const addition is quite new and is not everywhere. You can do the cleanup commit if you want.

This revision is now accepted and ready to land.Feb 28 2021, 9:52 PM

Closed by commit rB71ed6f32d2e3: Fix T84658: Anisotropic BSDF - most modes not using Screen Space (authored by Philipp Oeser (lichtwerk)). · Explain WhyMar 1 2021, 9:07 AM

This revision was automatically updated to reflect the committed changes.

Philipp Oeser (lichtwerk) added a commit: rB71ed6f32d2e3: Fix T84658: Anisotropic BSDF - most modes not using Screen Space.

Revision Contents
Changeset List

Path

Size

source/

blender/

gpu/

shaders/

material/

gpu_shader_material_anisotropic.glsl

7 lines

nodes/

shader/

nodes/

node_shader_bsdf_anisotropic.c

9 lines

Diff 34509

source/blender/gpu/shaders/material/gpu_shader_material_anisotropic.glsl

Loading...

source/blender/nodes/shader/nodes/node_shader_bsdf_anisotropic.c

Loading...