Fix T85824: Transition between adjustment regression
ClosedPublic
Actions

Authored by Richard Antalik (ISS) on Mar 1 2021, 4:57 AM.

Details

Reviewers

Sergey Sharybin (sergey)

Maniphest Tasks

T85824: Sequencer : Cross Fade between adjustement layer strips not working since 2.9

Commits

rBc81dfa242608: Fix T85824: Transition between adjustment regression

Summary

When transition effect is placed between 2 adjustment layer strips,
only first adjustment layer was rendered by effect.

Limit timeline_frame range to adjustment strip frame range.

This timeline configuration is technically invalid, because strips
should overlap when using transition effect. This was never restricted
and instead of producing no image, transition effect used first and
last frame of source strip. Many users got used to this "feature" so
I think it make sense to fix this case so it behaves like other strip
types.

Diff Detail

Repository: rB Blender

Event Timeline

Richard Antalik (ISS) requested review of this revision.Mar 1 2021, 4:57 AM

Richard Antalik (ISS) created this revision.

Harbormaster completed remote builds in B13160: Diff 34575.Mar 1 2021, 4:57 AM

Peter Fog (tintwotin) added projects: Video Sequencer, VFX & Video.Mar 1 2021, 4:34 PM

Sergey Sharybin (sergey) added inline comments.Mar 1 2021, 4:34 PM

source/blender/sequencer/intern/effects.c
3026	Add explanation about the clamping. Having a comment is always living with the code, which commit message gets faded away with time. You can make the commit message more terse, but have more explanation in the code which is not obvious at a glance :)