Page MenuHome

Fix T86060: Texture Paint clone tool misleading texture UI
AbandonedPublic

Authored by Philipp Oeser (lichtwerk) on Mar 1 2021, 1:37 PM.

Details

Summary

As far as I can tell, the Texture specified in the Texture Panel is not
used with the Clone tool at all (Texture Mask is still effective
though).

(it is a bit of a different story in the Image Editor, the Clone tool
works a little differently there since you have to choose a clone image
in that case).

For 3D view projection painting, I would suggest the following for the
Clone tool:

  • remove the Texture from viewport stencil drawing
  • remove/deactivate the Texture panel

Taking a step back, one could even argue that this is true for other
tools as well (Smear, Soften, Mask, I am looking at you), so I am not
sure if this is more of a Design decision or how to handle these...

Diff Detail

Repository
rB Blender
Branch
T86060 (branched from master)
Build Status
Buildable 13167
Build 13167: arc lint + arc unit

Event Timeline

Philipp Oeser (lichtwerk) requested review of this revision.Mar 1 2021, 1:37 PM

Committed rBafcfc6eb0842b9208bde3e334e3113a73807f6be, with changes:

  • Check the painting mode in paint_draw_tex_overlay.
  • As suggested, don't show the texture for mask, smear, soften... etc.

Strange I didn't get an e-mail notification on 1:st of March when you first added me as a subscriber, but I was notified today.

I just went through the brushes in texture paint mode in the 3d view and my findings are the same as yours:

Brush nameTextureTexture mask
DrawYesYes
SoftenNoYes
SmearNoYes
CloneNoYes
FillNoNo
MaskNoYes