Page MenuHome

VSE: Text strip preset tweaks
ClosedPublic

Authored by Peter Fog (tintwotin) on Mar 1 2021, 7:21 PM.
Tokens
"Love" token, awarded by dulrich."Love" token, awarded by abdo25."Love" token, awarded by mal_cando."Love" token, awarded by Andrea_Monzini."Like" token, awarded by ramenlook.

Details

Summary

This patch has been split from: D10542

The trouble with the current defaults are ex. that the text size is that small it'll only fit for SD resolution(which is not the current default resolution), it is placed at the very bottom, where no one will need it(not as subtitles nor title), and you'll miss it if you have the preview zoomed just a bit in, there is no text wrapping, who would need adding text outside of the screen as a default? The margin is moving in odd increments, and why should it be in fractions, it's a magic number no matter what. Also the position ranges are currently way too limited(0->1) to do rolling credits, or have large text animated in or out of the screen.

The defaults has been changed along these lines: D7768
Center the text vertically.
Make font larger(default project is not in SD anymore).
Set wrap to 1 - wrapping at screen edge - as default.
Make box transparent(looks better).
Allow shadows on texts when box.
Add decorate to margin. This will fix bad aligning of buttons and expose the fact that this value can be animated.
Change text shadow to lower right direction in alignment with the box shadow.
Make range for font size and position larger, so large sized text can be animated in and out of the preview area. This is useful for ex. rolling credits, or scrolling through frame titles.

A vote on Twitter revealed that those users voting would prefer shadow on text(b) instead of shadow on box(a): https://twitter.com/tintwotin/status/1372608142043930636


So the box shadow has been removed.

If the box color is dark and transparent it works both on dark and light backgrounds and with a white text(also default), so this has been changed to a default setting like this:

And the text shadow has also become slightly transparent, to match the transparency of the box:

Defaults Before:

Defaults After:

Position Range. Title scroll through. Before/After:

Position Range. Rolling Credits. Before/After:

NOTES:

  • The text entry box limits strings to something like 256 characters, which is far too little for rolling credits.
  • The text in the preview updates with value changes, it would be nice if the same thing would happen when typing in text.
  • Shift+Return should add carriage-returns.
  • Add-on for converting Text Editor contents to strip(s): https://github.com/tin2tin/text_to_strip

Diff Detail

Event Timeline

Peter Fog (tintwotin) requested review of this revision.Mar 1 2021, 7:21 PM
Peter Fog (tintwotin) created this revision.
Peter Fog (tintwotin) edited the summary of this revision. (Show Details)
Peter Fog (tintwotin) edited the summary of this revision. (Show Details)Mar 1 2021, 7:24 PM
Peter Fog (tintwotin) retitled this revision from VSE: Text Editor preset tweaks to VSE: Text strip preset tweaks.Mar 1 2021, 9:05 PM

Sending some of my concerns I would like you to clarify reasoning.

I probably shouldn't be concerned about text shadow. I doubt, that it was carefully crafted into current shape anyway.

I was thinking perhaps text size could be defined as fraction of resolution so it always looks same size. Assuming reasonable ratios of course.
This is just suggestion though.

source/blender/makesrna/intern/rna_sequencer.c
2867–2868

Not sure why you increase this limit, I think that 5000 is still usable though (in case somebody needs it)
this is just suggestion though.

at 10000 glyph cache takes around 10GB of RAM, that's quite too much.

2890

If I understad you correctly, you want this for subtitles right?

My idea was to use either very tall scene with very long text and animate strip transform Y position. Or very tall image and same workflow. That's quite besides the point.

Idea with these sliders are, that they shouldn't allow text to get off screen (too much). That's idea of 0-1 range. This is not hard limit though, so you can type in any number you want.

I don't think this is good change.

2903–2905

As I said above about 0-1 range applies here.

Behavior is same as if you do RNA_def_property_ui_range(prop, 0.0, 1.0, 0.01, -1)

I am so glad that the text tool is getting a revision. I literally gave up on it due to the weird defaults. The inability to scroll or roll the text seemed especially odd. In other applications I notice that large rolls are rendered out as animations to save memory footprint. Also is there an opportunity to improve the flexibility of the drop shadow function? For direction, offset and softness?

A percentage for scale is useful for relative changes but access to pixel size can be important for some use cases. For example when making television commercials you may find that there are legal requirements to show written details at a particular pixel height for clarity.

Peter Fog (tintwotin) edited the summary of this revision. (Show Details)Mar 3 2021, 5:48 AM
Peter Fog (tintwotin) edited the summary of this revision. (Show Details)Mar 3 2021, 9:36 AM

@Peter Fog (tintwotin) would you be fine commiting this with what I suggested in https://developer.blender.org/D10571#inline-85610 ?
I would rather avoid having versioning code for just this property and again 0-1 range is preffered.

Otherwise I am fine with these changes.

Peter Fog (tintwotin) edited the summary of this revision. (Show Details)

The box margin range change has been abandoned, so it's back to 0->1.

A vote on Twitter revealed that those users voting would prefer shadow on text(b) instead of shadow on box(a): https://twitter.com/tintwotin/status/1372608142043930636


So the box shadow has been removed.

If the box color is dark and transparent it works both on dark and light backgrounds and with a white text(also default), so this has been changed like this:

And the text shadow has also become slightly transparent, to match the transparency of the box:

Peter Fog (tintwotin) edited the summary of this revision. (Show Details)Mar 18 2021, 9:50 PM

The box margin range change has been abandoned, so it's back to 0->1.

Doesn't seem like it is in RNA definition

Peter Fog (tintwotin) marked 2 inline comments as done.Mar 19 2021, 6:51 AM
This revision is now accepted and ready to land.Mar 20 2021, 12:45 AM
This revision was automatically updated to reflect the committed changes.