Page MenuHome

Move settings and receipts into looper
ClosedPublic

Authored by Anna Sirota (railla) on Mar 5 2021, 4:13 PM.

Details

Summary

Moves reusable settings and receipt templates and views into looper.

Diff Detail

Event Timeline

Anna Sirota (railla) requested review of this revision.Mar 5 2021, 4:13 PM
Anna Sirota (railla) created this revision.
Anna Sirota (railla) retitled this revision from [WIP] Isolate looper from DevFund to Move settings and receipts into looper.Mar 9 2021, 11:58 AM
Anna Sirota (railla) edited the summary of this revision. (Show Details)
Sybren A. Stüvel (sybren) requested changes to this revision.Mar 9 2021, 12:15 PM

Conceptually it's a nice cleanup. Just some notes about the use of import.

blender_fund_main/urls.py
4–6

The shortness of the name should reflect the locality of that name. Now the symbols from another module are imported directly, whereas the local settings module requires settings.xxx.

I'd say use from looper.views import settings as looper_settings and then using looper_settings.xxxx.

looper/views/settings.py
11–12

Either do from .. import exceptions, forms, models, pdf or split everything up into separate lines.

This revision now requires changes to proceed.Mar 9 2021, 12:15 PM
  • Fix a 2-line import of looper modules
  • Import as looper_settings
Anna Sirota (railla) marked 2 inline comments as done.Mar 9 2021, 12:21 PM
This revision is now accepted and ready to land.Mar 9 2021, 12:43 PM