Fix T86355: Added effect strip has wrong length
ClosedPublic
Actions

Authored by Richard Antalik (ISS) on Mar 7 2021, 1:50 PM.

Details

Reviewers

Sergey Sharybin (sergey)

Maniphest Tasks

T86355: sequences.new_effect() parameter frame_end always gets treated as 0

Commits

rB3433d1b7f43a: Fix T86355: Added effect strip has wrong length

Summary

SEQ_add_effect_strip used SeqLoadData.image.end_frame to set end
frame. This was mistake introduced in last refactoring patch.

Use effect data, not image data, when adding effect strips.

Diff Detail

Repository

rB Blender

Branch

T86355 (branched from master)

Build Status

Buildable 13301
Build 13301: arc lint + arc unit

Event Timeline

Richard Antalik (ISS) requested review of this revision.Mar 7 2021, 1:50 PM

Richard Antalik (ISS) created this revision.

Harbormaster completed remote builds in B13301: Diff 34846.Mar 7 2021, 1:50 PM

Sergey Sharybin (sergey) accepted this revision.Mar 8 2021, 10:23 AM

This revision is now accepted and ready to land.Mar 8 2021, 10:23 AM

Closed by commit rB3433d1b7f43a: Fix T86355: Added effect strip has wrong length (authored by Richard Antalik (ISS)). · Explain WhyMar 20 2021, 1:43 AM

This revision was automatically updated to reflect the committed changes.

Richard Antalik (ISS) added a commit: rB3433d1b7f43a: Fix T86355: Added effect strip has wrong length.

Revision Contents
Changeset List

Path

Size

source/

blender/

editors/

space_sequencer/

sequencer_add.c

1 line

sequencer/

intern/

strip_add.c

3 lines

Diff 34846

View Options

source/blender/editors/space_sequencer/sequencer_add.c