Page MenuHome
Differential D10638

FFMPEG: refactor seeking
ClosedPublic
Actions

Authored by Richard Antalik (ISS) on Mar 8 2021, 4:12 AM.

Details

Reviewers
Sergey Sharybin (sergey)
Commits
rB847002e1f88b: FFMPEG: refactor seeking
Summary

Split seeking section of ffmpeg_fetchibuf() function into multiple
smaller functions.

Conditional statements are moved to own funtions with human readable
names, so code flow is more clear.

To remove one branch of seeking, first frame is now decoded by
scanning, which will do only one iteration. So nothing has technically
changed.

Diff Detail

Repository
rB Blender

Event Timeline

Richard Antalik (ISS) requested review of this revision.Mar 8 2021, 4:12 AM
Richard Antalik (ISS) created this revision.
Harbormaster completed remote builds in B13308: Diff 34858.Mar 8 2021, 4:12 AM
Richard Antalik (ISS) updated this revision to Diff 34859.Mar 8 2021, 4:29 AM
  • Minor tweaks
Harbormaster completed remote builds in B13309: Diff 34859.Mar 8 2021, 4:29 AM
Richard Antalik (ISS) edited the summary of this revision. (Show Details)Mar 8 2021, 4:49 AM
Richard Antalik (ISS) added a reviewer: Sergey Sharybin (sergey).
Sergey Sharybin (sergey) added a comment.Mar 8 2021, 10:26 AM

Generally looks fine.
While the knowledge is fresh, I would suggest adding comments about these new functions. For example, what does it exactly mean ffmpeg_can_scan/ ffmpeg_can_seek.

Richard Antalik (ISS) mentioned this in D6392: FFMPEG frame seek bug fix.Mar 18 2021, 3:02 AM
Richard Antalik (ISS) updated this revision to Diff 35498.Mar 23 2021, 9:40 AM
  • Add comment explaining ffmpeg_can_scan and ffmpeg_can_seek functions
Harbormaster completed remote builds in B13673: Diff 35498.Mar 23 2021, 9:40 AM
Sergey Sharybin (sergey) accepted this revision.Mar 26 2021, 12:07 PM
This revision is now accepted and ready to land.Mar 26 2021, 12:07 PM
Closed by commit rB847002e1f88b: FFMPEG: refactor seeking (authored by Richard Antalik (ISS)). · Explain WhyMar 26 2021, 12:46 PM
This revision was automatically updated to reflect the committed changes.
Richard Antalik (ISS) added a commit: rB847002e1f88b: FFMPEG: refactor seeking.

Revision Contents
Changeset List

PathSize
source/
blender/
imbuf/
intern/
333 lines

Diff 35618

View Options

source/blender/imbuf/intern/anim_movie.c

Loading...