Page MenuHome

Fix T86373: crash picking colors in geometry nodesockets
ClosedPublic

Authored by Philipp Oeser (lichtwerk) on Mar 8 2021, 1:40 PM.

Details

Summary

Caused by rB85421c4fab02: Geometry Nodes: Attribute search drop-down.

Above commit treated SOCK_RGBA and SOCK_STRING the same in
std_node_socket_draw.
That would turn a RGBA button into a text button (for attribute search),
leading to trouble.
Note these were just treated the same prior to above commit because both
were doing the layout split.

Now just give RGBA sockets their own case.

Diff Detail

Repository
rB Blender

Event Timeline

Philipp Oeser (lichtwerk) requested review of this revision.Mar 8 2021, 1:40 PM
Philipp Oeser (lichtwerk) created this revision.

Oops, thanks for fixing that.

This revision is now accepted and ready to land.Mar 8 2021, 1:43 PM

Yikes, thanks Philipp.

We also have to thank the army of testers, catching those things (kindof) early (in this case: thx @Clóvis (Clovis) !)