Page MenuHome
Differential D10658

Add DNA defaults for UnifiedPaintSettings
ClosedPublic
Actions

Authored by Siddhartha Jejurkar (sidd017) on Mar 9 2021, 10:58 AM.

Details

Reviewers
Campbell Barton (campbellbarton)
Group Reviewers
User Interface
Maniphest Tasks
T80164: Missing DNA Defaults ("Reset to Default Value" sets to 0)
Summary

Add DNA defaults for Unified Paint Settings.
Ref T80164

Diff Detail

Event Timeline

Siddhartha Jejurkar (sidd017) requested review of this revision.Mar 9 2021, 10:58 AM
Siddhartha Jejurkar (sidd017) created this revision.
Ankit Meel (ankitm) edited the summary of this revision. (Show Details)Mar 9 2021, 6:23 PM
Ankit Meel (ankitm) added a task: T80164: Missing DNA Defaults ("Reset to Default Value" sets to 0).
Siddhartha Jejurkar (sidd017) updated this revision to Diff 34994.Mar 9 2021, 10:35 PM

Previous diff was invalid since it didn't resolve the original issue (invalid defaults). This updated diff fixes the problem by assigning the correct default struct to unified_paint_settings.

Also added defaults for Unprojected Radius, Color and Secondary Color.

Pratik Borhade (PratikPB2123) edited the summary of this revision. (Show Details)Mar 10 2021, 2:24 AM
Pratik Borhade (PratikPB2123) added projects: User Interface, Good First Issue, Restricted Project.
Pratik Borhade (PratikPB2123) edited the summary of this revision. (Show Details)
Siddhartha Jejurkar (sidd017) added reviewers: User Interface, Good First Issue.Mar 10 2021, 5:00 AM
Siddhartha Jejurkar (sidd017) set the repository for this revision to rB Blender.
Siddhartha Jejurkar (sidd017) removed a reviewer: Good First Issue.Mar 10 2021, 5:10 AM
Campbell Barton (campbellbarton) mentioned this in rB122fefcc8589: DNA: add defaults for UnifiedPaintSettings.Mar 10 2021, 11:46 AM
Campbell Barton (campbellbarton) accepted this revision.Mar 10 2021, 11:47 AM
Campbell Barton (campbellbarton) added a subscriber: Campbell Barton (campbellbarton).

Thanks, committed rB122fefcc8589a09d4e89ed3045f29f07ec6564e9

source/blender/makesdna/DNA_scene_defaults.h
293–294

These values are zeroed in the default scene, so left zeroed for the defaults too. Also added flag members.

This revision is now accepted and ready to land.Mar 10 2021, 11:47 AM
Campbell Barton (campbellbarton) closed this revision.Mar 10 2021, 11:48 AM

Revision Contents
Changeset List

PathSize
source/
blender/
makesdna/
12 lines
intern/
1 line
makesrna/
intern/
2 lines

Diff 34994

View Options

source/blender/makesdna/DNA_scene_defaults.h

Loading...
View Options

source/blender/makesdna/intern/dna_defaults.c

Loading...
View Options

source/blender/makesrna/intern/rna_scene.c

Loading...