Differential D1065

BGE BL_KetsjiEmbedStart, unneded if-else
ClosedPublic
Actions

Authored by Jorge Bernal (lordloki) on Feb 5 2015, 9:01 AM.

Tags

Subscribers

Jorge Bernal (lordloki)

Details

Reviewers

Pierluigi Grassi (pgi)
Dalai Felinto (dfelinto)
Mitchell Stokes (moguri)

Summary

There's an if-else in BL_KetsjiEmbedStart that isn't really needed. Probably a left over from an older patch (in older files SetCameraOverrideClipping(v3d->near, v3d->far) had a minus sign over one of the arguments, the minus has been later on removed).

This is the same as https://developer.blender.org/T43565

Diff Detail

Event Timeline

Pierluigi Grassi (pgi) updated this revision to Diff 3364.Feb 5 2015, 9:01 AM

Pierluigi Grassi (pgi) retitled this revision from to BGE BL_KetsjiEmbedStart, unneded if-else.

Pierluigi Grassi (pgi) updated this object.

Pierluigi Grassi (pgi) added a project: Game Engine.

Based on the following tracking from dfelinto (https://developer.blender.org/T28893 and http://lists.blender.org/pipermail/bf-blender-cvs/2013-February/053885.html) it seems the right choice.

Looks good to me

Jorge Bernal (lordloki) accepted this revision.Feb 5 2015, 10:22 PM

Jorge Bernal (lordloki) added a reviewer: Jorge Bernal (lordloki).

This revision is now accepted and ready to land.Feb 5 2015, 10:22 PM

Mitchell Stokes (moguri) accepted this revision.Feb 6 2015, 12:50 AM

Mitchell Stokes (moguri) edited edge metadata.

Closing by commit 2b01b713394.

pgi, thanks a lot for the patch.

Jorge Bernal (lordloki) closed this revision.Feb 13 2015, 8:16 AM

Revision Contents
Changeset List

Path

Size

source/

gameengine/

BlenderRoutines/

BL_KetsjiEmbedStart.cpp

9 lines

Diff 3364

source/gameengine/BlenderRoutines/BL_KetsjiEmbedStart.cpp

Loading...