UI: Make Scene strip panel consistent with current UI styles
ClosedPublic
Actions

Authored by Peter Fog (tintwotin) on Mar 9 2021, 1:36 PM.

Details

Reviewers

Richard Antalik (ISS)

Group Reviewers

User Interface

Commits

rB8b3f5f755edc: VSE UI: Cleanup scene panel style

Summary

The scene setting was not using property_split.
Camera setting was off-centered.
Volume was missing decorate(though it is possible to animate the value).
Volume was placed in between the camera settings.
GP and Transparent was not using Heading.

Before/After:

.blend with scene strip properties exposed:

scene_strip.blend641 KBDownload

Diff Detail

Event Timeline

Peter Fog (tintwotin) requested review of this revision.Mar 9 2021, 1:36 PM

Peter Fog (tintwotin) created this revision.

Peter Fog (tintwotin) edited the summary of this revision. (Show Details)Mar 9 2021, 1:49 PM

Peter Fog (tintwotin) edited the summary of this revision. (Show Details)Mar 9 2021, 1:58 PM

William Reynish (billreynish) awarded a token.Mar 9 2021, 3:01 PM

Peter Fog (tintwotin) added a project: Video Sequencer.Mar 9 2021, 7:52 PM

Peter Fog (tintwotin) added a reviewer: User Interface.Mar 10 2021, 10:59 AM

Andrea Monzini (Andrea_Monzini) awarded a token.Mar 10 2021, 1:58 PM

Stig Oskar (Stig) awarded a token.Mar 10 2021, 3:36 PM

Apart from whitespace issues, seems OK

This revision is now accepted and ready to land.Mar 18 2021, 5:43 PM

Hans Goudey (HooglyBoogly) added a subscriber: Hans Goudey (HooglyBoogly).Mar 18 2021, 7:57 PM

Hans Goudey (HooglyBoogly) added inline comments.

release/scripts/startup/bl_ui/space_sequencer.py
1432–1438	What's all this extra logic for? Why not the following? layout.prop(scene, "audio_volume", text="Volume")
1449	Extra new-line here

Peter Fog (tintwotin) marked an inline comment as done.Mar 18 2021, 10:25 PM

Peter Fog (tintwotin) added inline comments.

release/scripts/startup/bl_ui/space_sequencer.py
1432–1438	It's because it'll be misaligned without it:

Remove extra line.

Remove empty line.

Hans Goudey (HooglyBoogly) added inline comments.Mar 18 2021, 10:33 PM

release/scripts/startup/bl_ui/space_sequencer.py
1432–1438	Ah, weird, okay, thanks. Maybe add a comment saying that, like this maybe? `# Build a manual split layout as a hack to get proper alignment with the rest of the buttons.`