Fix T86370: Select color for glow is inverted
ClosedPublic
Actions

Authored by Falk David (filedescriptor) on Mar 9 2021, 5:54 PM.

Details

Reviewers

Antonio Vazquez (antoniov)
Clément Foucault (fclem)

Maniphest Tasks

T86370: Grease Pencil, effect, glow color select is inversed

Commits

rB2ca48b967894: Fix T86370: Select color for glow is inverted

Summary

The shader was filtering everything but the selected color.
The fix inverts the check to make sure that color is selected.

Diff Detail

Repository

rB Blender

Branch

T86370 (branched from master)

Build Status

Buildable 13370
Build 13370: arc lint + arc unit

Event Timeline

Falk David (filedescriptor) requested review of this revision.Mar 9 2021, 5:54 PM

Falk David (filedescriptor) created this revision.

Harbormaster completed remote builds in B13370: Diff 34975.Mar 9 2021, 5:54 PM

Falk David (filedescriptor) added a child revision: D10672: GPencil: glow fx, add threshold value color mode.Mar 9 2021, 6:31 PM

@Clément Foucault (fclem) Can you review this small change? You know better than me was going on in the shader.

Clément Foucault (fclem) accepted this revision.Mar 13 2021, 9:57 PM

This revision is now accepted and ready to land.Mar 13 2021, 9:57 PM

Closed by commit rB2ca48b967894: Fix T86370: Select color for glow is inverted (authored by Falk David (filedescriptor)). · Explain WhyMar 15 2021, 9:52 AM

This revision was automatically updated to reflect the committed changes.

Falk David (filedescriptor) added a commit: rB2ca48b967894: Fix T86370: Select color for glow is inverted.

Revision Contents
Changeset List

Path

Size

source/

blender/

draw/

engines/

gpencil/

shaders/

gpencil_vfx_frag.glsl

2 lines

Diff 34975

View Options

source/blender/draw/engines/gpencil/shaders/gpencil_vfx_frag.glsl

Fix T86370: Select color for glow is invertedClosedPublicActions