Add 'foreach_nodeclass' for geometry nodetrees
ClosedPublic
Actions

Authored by Philipp Oeser (lichtwerk) on Mar 9 2021, 6:35 PM.

Details

Reviewers

Jacques Lucke (JacquesLucke)

Maniphest Tasks

T86416: Crash in node menu of the texture properties

Commits

rBcf2933c38a34: Add 'foreach_nodeclass' for geometry nodetrees

Summary

This also changes some of the more permissive poll functions on some
nodes back to being "shading-only" (these were made permissive in
rBb78f2675d7e5 for simulation nodes, but have not found their way into
geometry nodes yet).

ref b279fef85d1a / T86416 / D10671

Diff Detail

Repository

rB Blender

Branch

T86416_c (branched from master)

Build Status

Buildable 13375
Build 13375: arc lint + arc unit

Event Timeline

Philipp Oeser (lichtwerk) requested review of this revision.Mar 9 2021, 6:35 PM

Philipp Oeser (lichtwerk) created this revision.

Harbormaster completed remote builds in B13375: Diff 34980.Mar 9 2021, 6:35 PM

Philipp Oeser (lichtwerk) added a project: Geometry Nodes.Mar 9 2021, 6:35 PM

Philipp Oeser (lichtwerk) mentioned this in D10674: Fix (unreported) geometry node attribute search not working in the Properties Editor.Mar 9 2021, 7:11 PM

Philipp Oeser (lichtwerk) mentioned this in T86416: Crash in node menu of the texture properties.Mar 9 2021, 7:15 PM

I'm not exactly how it relates here, but there are other categories used in geometry nodes too, right? For utility nodes, color nodes, etc.

source/blender/nodes/geometry/node_geometry_tree.cc
77	Typo

In D10673#270122, @Hans Goudey (HooglyBoogly) wrote:

I'm not exactly how it relates here, but there are other categories used in geometry nodes too, right? For utility nodes, color nodes, etc.

Yes, there are a couple more, but I have to tweak the node poll functions a bit for them first (otherwise it would be possible for example to pull in a [non-functional] Combine HSV node here)