Page MenuHome
Differential D10674

Fix (unreported) geometry node attribute search not working in the Properties Editor
ClosedPublic
Actions

Authored by Philipp Oeser (lichtwerk) on Mar 9 2021, 7:11 PM.

Details

Reviewers
Hans Goudey (HooglyBoogly)
Maniphest Tasks
T86416: Crash in node menu of the texture properties
Commits
rB53b82efed66b: Fix (unreported) geometry node attribute search not working in the
Summary

Since rBb279fef85d1a, the nodes properties for geometry nodes using a
texture are displayed in the Properties Editor.

rB85421c4fab02 added an attribute search button, but this was missing
still (gave just the regular text button) if this was displayed in the
Properties Editor.

ref b279fef85d1a / T86416 / D10671 / D10673

Diff Detail

Repository
rB Blender

Event Timeline

Philipp Oeser (lichtwerk) requested review of this revision.Mar 9 2021, 7:11 PM
Philipp Oeser (lichtwerk) created this revision.
Harbormaster completed remote builds in B13376: Diff 34983.Mar 9 2021, 7:11 PM
Philipp Oeser (lichtwerk) added a project: Geometry Nodes.Mar 9 2021, 7:12 PM
Philipp Oeser (lichtwerk) mentioned this in T86416: Crash in node menu of the texture properties.Mar 9 2021, 7:15 PM
Hans Goudey (HooglyBoogly) accepted this revision.Mar 9 2021, 11:21 PM

It's nice that this works, sort of surprising actually. Thanks for the patch.

source/blender/editors/space_node/node_templates.c
840–841

Best to put this after the if, else checks so we get the blank space in both cases.

This revision is now accepted and ready to land.Mar 9 2021, 11:21 PM
Closed by commit rB53b82efed66b: Fix (unreported) geometry node attribute search not working in the (authored by Philipp Oeser (lichtwerk)). · Explain WhyMar 10 2021, 12:07 AM
This revision was automatically updated to reflect the committed changes.
Philipp Oeser (lichtwerk) added a commit: rB53b82efed66b: Fix (unreported) geometry node attribute search not working in the.

Revision Contents
Changeset List

PathSize
source/
blender/
editors/
space_node/
13 lines

Diff 35005

View Options

source/blender/editors/space_node/node_templates.c

Loading...