Page MenuHome
Differential D10681

Spreadsheet: Expose more domains and point cloud data.
ClosedPublic
Actions

Authored by Jacques Lucke (JacquesLucke) on Mar 10 2021, 1:52 PM.

Details

Reviewers
Hans Goudey (HooglyBoogly)
Simon Thommes (simonthommes)
Maniphest Tasks
T86135: Expose other domains for attribute spreadsheet as menu entry
Commits
rB5f1f233dc97d: Spreadsheet: expore more domains and point cloud data
Summary

Ref T86135.

Diff Detail

Repository
rB Blender

Event Timeline

Jacques Lucke (JacquesLucke) requested review of this revision.Mar 10 2021, 1:52 PM
Jacques Lucke (JacquesLucke) created this revision.
Harbormaster completed remote builds in B13400: Diff 35021.Mar 10 2021, 1:52 PM
Jacques Lucke (JacquesLucke) edited the summary of this revision. (Show Details)Mar 10 2021, 1:56 PM
Jacques Lucke (JacquesLucke) added a reviewer: Hans Goudey (HooglyBoogly).
Jacques Lucke (JacquesLucke) edited the summary of this revision. (Show Details)Mar 10 2021, 1:59 PM
Jacques Lucke (JacquesLucke) added a task: T86135: Expose other domains for attribute spreadsheet as menu entry.
Jacques Lucke (JacquesLucke) added a reviewer: Simon Thommes (simonthommes).Mar 10 2021, 3:14 PM
Hans Goudey (HooglyBoogly) accepted this revision.Mar 10 2021, 4:10 PM

This is great. It's already so helpful. I would suggest putting these drop-downs to the left of the breadcrumbs / object name label and pin icon.

source/blender/editors/space_spreadsheet/spreadsheet_from_geometry.cc
514–521

I would expect this to be an IndexMask, does that make sense? A separate cleanup though, possibly.

source/blender/makesrna/intern/rna_space.c
7274

A simpler phrasing is "Part of the geometry to show data from"

7282

I think "display" is better than "show" (D10551)

This revision is now accepted and ready to land.Mar 10 2021, 4:10 PM
Jacques Lucke (JacquesLucke) added inline comments.Mar 10 2021, 4:26 PM
source/blender/editors/space_spreadsheet/spreadsheet_from_geometry.cc
514–521

Right now it could be an IndexMask. However, as soon as sorting is supported, this does not work anymore. An IndexMask has the invariant that it is always sorted (because that allows some optimizations).

Jacques Lucke (JacquesLucke) updated this revision to Diff 35034.Mar 10 2021, 4:27 PM
  • improve descriptions
  • move dropdowns to the left
Harbormaster completed remote builds in B13412: Diff 35034.Mar 10 2021, 4:27 PM
Hans Goudey (HooglyBoogly) added inline comments.Mar 10 2021, 5:21 PM
source/blender/editors/space_spreadsheet/spreadsheet_from_geometry.cc
514–521

Ah right, forgot about that. Thanks.

Closed by commit rB5f1f233dc97d: Spreadsheet: expore more domains and point cloud data (authored by Jacques Lucke (JacquesLucke)). · Explain WhyMar 11 2021, 12:23 PM
This revision was automatically updated to reflect the committed changes.
Jacques Lucke (JacquesLucke) added a commit: rB5f1f233dc97d: Spreadsheet: expore more domains and point cloud data.
Charlie Jolly (charlie) awarded a token.Mar 11 2021, 1:37 PM

Revision Contents
Changeset List

PathSize
release/
scripts/
startup/
bl_ui/
3 lines
source/
blender/
editors/
space_spreadsheet/
2 lines
147 lines
makesdna/
7 lines
makesrna/
intern/
72 lines

Diff 35060

View Options

release/scripts/startup/bl_ui/space_spreadsheet.py

Loading...
View Options

source/blender/editors/space_spreadsheet/space_spreadsheet.cc

Loading...
View Options

source/blender/editors/space_spreadsheet/spreadsheet_from_geometry.cc

Loading...
View Options

source/blender/makesdna/DNA_space_types.h

Loading...
View Options

source/blender/makesrna/intern/rna_space.c

Loading...