Spreadsheet: Add status bar.
ClosedPublic
Actions

Authored by Jacques Lucke (JacquesLucke) on Mar 11 2021, 1:49 PM.

Details

Reviewers

Hans Goudey (HooglyBoogly)

Commits

rBb617b4441961: Spreadsheet: add status bar

Summary

This implements the status bar as footer region in the spreadsheet editor (T86142).
Currently, it just shows the number of rows and columns. More information can be added once it is available.

Diff Detail

Repository

rB Blender

Branch

spreadsheet-footer (branched from master)

Build Status

Buildable 13431
Build 13431: arc lint + arc unit

Event Timeline

Jacques Lucke (JacquesLucke) requested review of this revision.Mar 11 2021, 1:49 PM

Jacques Lucke (JacquesLucke) created this revision.

Harbormaster completed remote builds in B13429: Diff 35063.Mar 11 2021, 1:49 PM

Jacques Lucke (JacquesLucke) edited the summary of this revision. (Show Details)Mar 11 2021, 1:50 PM

Jacques Lucke (JacquesLucke) edited the summary of this revision. (Show Details)

Jacques Lucke (JacquesLucke) added a reviewer: Hans Goudey (HooglyBoogly).

For the records (brought this up over chat). Technically you can already use the "selected only" filter as a way to add more information to the status bar (the whole 2 / 14 rows).

take selected status into account

Harbormaster completed remote builds in B13431: Diff 35067.Mar 11 2021, 4:31 PM

Personally I have some problems with the design, but I posted that on the design task. The code looks good to me.
I think storing the necessary variables for the footer and tagging redraw is the best way to do it, so +1 for that.

Looks like a call to rna_def_space_generic_show_region_toggles might be missing.

source/blender/editors/space_spreadsheet/space_spreadsheet.cc
65	`/* Footer. */` : P
265	I'd get a reference to `SpaceSpreadsheet_Runtime` directly so you don't have to keep repeating `spreadsheet->runtime` in the following lines.