Add WASAPI
ClosedPublic
Actions

Authored by Joerg Mueller (nexyon) on Mar 11 2021, 7:30 PM.

Details

Reviewers

Ray Molenkamp (LazyDodo)

Maniphest Tasks

T86590: Audaspace: Use platform native audio APIs

Commits

rBbc5798530663: Audaspace: add support for WASAPI on Windows

Summary

This adds WASAPI as audio backend for Blender on Windows. WASAPI is the windows audio session API, i.e. a standard API that is available on Windows by default.

Diff Detail

Event Timeline

Joerg Mueller (nexyon) requested review of this revision.Mar 11 2021, 7:30 PM

Joerg Mueller (nexyon) created this revision.

TheRedWaxPolice (TheRedWaxPolice) added a subscriber: TheRedWaxPolice (TheRedWaxPolice).Mar 11 2021, 7:48 PM

Builds with no issues, but no output, i can take a closer look why when i find some spare time

This revision now requires changes to proceed.Mar 11 2021, 8:04 PM

Peter Fog (tintwotin) awarded a token.Mar 11 2021, 8:53 PM

I've updated the implementation for the case where the API changes the pointer (not following the documentation here: https://docs.microsoft.com/en-us/windows/win32/api/audioclient/nf-audioclient-iaudioclient-isformatsupported).

TheRedWaxPolice (TheRedWaxPolice) awarded a token.Mar 12 2021, 4:27 AM

This update fixes a minor issue, where playback wouldn't start properly due to a wrong buffer size.

Given virtually 99% of this patch is in /extern there is not much to review here.

This revision is now accepted and ready to land.Mar 13 2021, 8:53 PM

Brecht Van Lommel (brecht) added a subscriber: Brecht Van Lommel (brecht).Mar 15 2021, 4:57 PM

Brecht Van Lommel (brecht) added inline comments.

CMakeLists.txt
315	Expand the description to read `"Enable Windows Audio Session API for audio playback on Windows"` Could even use expand it in the name of the option too.