Page MenuHome

Nodes: Add Attribute Remove Node
ClosedPublic

Authored by Fabian Schempp (fabian_schempp) on Mar 11 2021, 10:29 PM.

Diff Detail

Repository
rB Blender

Event Timeline

Fabian Schempp (fabian_schempp) requested review of this revision.Mar 11 2021, 10:29 PM
Fabian Schempp (fabian_schempp) created this revision.

Nice and simple!

source/blender/nodes/geometry/nodes/node_geo_attribute_remove.cc
17–22 ↗(On Diff #35077)

Unused includes

42–43 ↗(On Diff #35077)

This is a common, expected situation, no need to add an error in this case.

47–48 ↗(On Diff #35077)

Personally I would skip assigning the temp variable here and just put the operation in the if statement.

48–49 ↗(On Diff #35077)

I'd like to be explicit and add the name of the attribute here, like the other related error messages

This revision is now accepted and ready to land.Mar 11 2021, 10:39 PM
  • Changes based on review by Hans Goudey.
  • Changes based on review by Hans Goudey.
This revision was automatically updated to reflect the committed changes.

Is it possible to have the Attribute input socket as a multi input socket? Some of the tools I've been making have up to 23 attributes that would need clearing out so accepting multiple string nodes would really streamline this

Is it possible to have the Attribute input socket as a multi input socket? Some of the tools I've been making have up to 23 attributes that would need clearing out so accepting multiple string nodes would really streamline this

That is something we plan on adding. It would require a new multiple-input socket, similar to the switch node design

Is it possible to have the Attribute input socket as a multi input socket? Some of the tools I've been making have up to 23 attributes that would need clearing out so accepting multiple string nodes would really streamline this

I already made that. But its not in master yet. D10698

That is something we plan on adding. It would require a new multiple-input socket, similar to the switch node design

@Eitan Traurig (EitanSomething) The new multi-input socket with sorting is already in master. You can use it for the switch node.