Fix T86168 : Add primitive Grid. Whong number of subdivisions
ClosedPublic
Actions

Authored by Pratik Borhade (PratikPB2123) on Mar 12 2021, 6:13 AM.

Details

Reviewers

Campbell Barton (campbellbarton)
Philipp Oeser (lichtwerk)

Maniphest Tasks

T86168: Add primitive Grid. Whong number of subdivisions

Summary

Fix T86168
Changes to increase subdivision by one along both axis ( X and Y )

changes while allocating memory at BMO_slot_buffer_alloc .
for loop iteration increased for extra subdivision .

eg . for x_segment = 3 and y_segment = 3 . there should be 16 vertices ( (3+1) * ( 3+1) ) for correct number of subdivisions . currently they are 3*3 =9 vertices

Diff Detail

Repository: rB Blender

Event Timeline

Pratik Borhade (PratikPB2123) requested review of this revision.Mar 12 2021, 6:13 AM

Pratik Borhade (PratikPB2123) created this revision.

Pratik Borhade (PratikPB2123) edited the summary of this revision. (Show Details)Mar 12 2021, 7:10 AM

Pratik Borhade (PratikPB2123) added a reviewer: Campbell Barton (campbellbarton).

Vyacheslav (hitrpr) awarded a token.Mar 12 2021, 9:12 PM

Pratik Borhade (PratikPB2123) added a reviewer: Philipp Oeser (lichtwerk).Mar 16 2021, 9:46 AM

Campbell Barton (campbellbarton) mentioned this in rB4d3cdb32d399: Fix T86168: Add primitive Grid. Wrong number of subdivisions.Mar 16 2021, 1:11 PM

Thanks, committed rB4d3cdb32d399335dba72c180309c0d34f93cd533

Adding the plane, minimum x/y values needed updating too.

This revision is now accepted and ready to land.Mar 16 2021, 1:12 PM

In the future, it's really helpful to have Differential Revision: https://developer.blender.org/D10699 in the commit message for easily accessing the patch from the commit.

Revision Contents
Changeset List

Path

Size

source/

blender/

bmesh/

operators/

bmo_primitive.c

20 lines

Diff 35092

View Options

source/blender/bmesh/operators/bmo_primitive.c

Fix T86168 : Add primitive Grid. Whong number of subdivisionsClosedPublicActions