Page MenuHome
Differential D10705

Cryptomatte: Show Name of Object/Material Under The Cursor.
ClosedPublic
Actions

Authored by Jeroen Bakker (jbakker) on Mar 12 2021, 3:46 PM.

Details

Reviewers
Julian Eisel (Severin)
Group Reviewers
User Interface
Commits
rB97defd9cd79b: Cryptomatte: Show Name of Object/Material Under The Cursor.
Summary

This change shows the object or material name with the cursor when picking for a cryptomatte node.

Depends on D3959: Compositor: Redesign Cryptomatte node for better usability

Diff Detail

Repository
rB Blender
Branch
temp-compositor-cryptomatte-picker
Build Status
Buildable 13533
Build 13533: arc lint + arc unit

Event Timeline

Jeroen Bakker (jbakker) requested review of this revision.Mar 12 2021, 3:46 PM
Jeroen Bakker (jbakker) created this revision.
Harbormaster completed remote builds in B13460: Diff 35108.Mar 12 2021, 3:46 PM
Jeroen Bakker (jbakker) edited the summary of this revision. (Show Details)Mar 12 2021, 3:47 PM
Jeroen Bakker (jbakker) added a reviewer: User Interface.
Jeroen Bakker (jbakker) added a parent revision: D3959: Compositor: Redesign Cryptomatte node for better usability.
Jeroen Bakker (jbakker) added inline comments.Mar 12 2021, 3:53 PM
source/blender/editors/interface/interface_eyedropper_color.c
92

we should call eyedropper_draw_cursor_text here.

Jeroen Bakker (jbakker) added inline comments.Mar 12 2021, 4:09 PM
source/blender/editors/interface/interface_eyedropper_color.c
92

The issue is that for this we need access to the context what isn't accessible by the windowmanager draw callback.

Jeroen Bakker (jbakker) updated this revision to Diff 35239.Mar 16 2021, 8:45 AM

Code cleanup use common function for drawing text near cursor.

Harbormaster completed remote builds in B13533: Diff 35239.Mar 16 2021, 8:45 AM
Jeroen Bakker (jbakker) added projects: BF Blender (2.93), User Interface.Mar 16 2021, 8:47 AM
Jeroen Bakker (jbakker) added inline comments.Mar 16 2021, 5:08 PM
source/blender/nodes/composite/nodes/node_composite_cryptomatte.cc
210

Revert this change

Julian Eisel (Severin) accepted this revision.Mar 16 2021, 6:28 PM
Julian Eisel (Severin) added a subscriber: Julian Eisel (Severin).

Happy to see this working! Just quickly scrolled over the code, didn't see anything troubling. Kinda annoying to have cryptomatte data in Eyedropper, but that's not new apparently and it's just a bit of local data, so don't mind much.

This revision is now accepted and ready to land.Mar 16 2021, 6:28 PM
Closed by commit rB97defd9cd79b: Cryptomatte: Show Name of Object/Material Under The Cursor. (authored by Jeroen Bakker (jbakker)). · Explain WhyMar 17 2021, 8:59 AM
This revision was automatically updated to reflect the committed changes.
Jeroen Bakker (jbakker) added a commit: rB97defd9cd79b: Cryptomatte: Show Name of Object/Material Under The Cursor..
Pablo Vazquez (pablovazquez) awarded a token.Mar 22 2021, 1:28 PM
Daniele De Luca (sparazza) awarded a token.Jul 8 2021, 1:01 AM

Revision Contents
Changeset List

PathSize
source/
blender/
blenkernel/
3 lines
editors/
interface/
35 lines
52 lines
2 lines
2 lines
7 lines
nodes/
composite/
nodes/
9 lines

Diff 35239

View Options

source/blender/blenkernel/BKE_node.h

Loading...
View Options

source/blender/editors/interface/interface_eyedropper.c

Loading...
View Options

source/blender/editors/interface/interface_eyedropper_color.c

Loading...
View Options

source/blender/editors/interface/interface_eyedropper_datablock.c

Loading...
View Options

source/blender/editors/interface/interface_eyedropper_depth.c

Loading...
View Options

source/blender/editors/interface/interface_eyedropper_intern.h

Loading...
View Options

source/blender/nodes/composite/nodes/node_composite_cryptomatte.cc

Loading...