Page MenuHome
Differential D10708

Fix T86463: Colored collection icons don't scale with zoom level
ClosedPublic
Actions

Authored by Leon Schittek (lone_noel) on Mar 12 2021, 10:55 PM.

Details

Reviewers
Nathan Craddock (natecraddock)
Julian Eisel (Severin)
Group Reviewers
User Interface
Maniphest Tasks
T86463: Colored collection icons in the collection search dropdown don't adjust to the zoom level in Geometry nodes editor
Commits
rB965425bcbc4d: Fix T86463: Colored collection icons don't scale with zoom level
Summary

This patch fixes the issue in T86463 that colored collection icons in the collection search box don't scale according to the zoom level.

The issue was caused by the drawing function for the colored collection icons not allowing to change the size of the icons. This patch addresses that by scaling the icon based on the drawing width.

Comparison

MasterPatch

Test file:

T86463_colored-collection-icon-zoom_test.blend882 KBDownload

Diff Detail

Repository
rB Blender
Branch
fix-T86463 (branched from master)
Build Status
Buildable 13470
Build 13470: arc lint + arc unit

Event Timeline

Leon Schittek (lone_noel) requested review of this revision.Mar 12 2021, 10:55 PM
Leon Schittek (lone_noel) created this revision.
Harbormaster completed remote builds in B13470: Diff 35125.Mar 12 2021, 10:55 PM
Leon Schittek (lone_noel) retitled this revision from Fix T86463: Colored collection icons dont scale with zoom level. to Fix T86463: Colored collection icons don't scale with zoom level.Mar 12 2021, 11:03 PM
Leon Schittek (lone_noel) edited the summary of this revision. (Show Details)
Leon Schittek (lone_noel) added a project: User Interface.
Leon Schittek (lone_noel) added a reviewer: User Interface.Mar 12 2021, 11:22 PM
Leon Schittek (lone_noel) added a project: Geometry Nodes.
Hans Goudey (HooglyBoogly) added a task: T86463: Colored collection icons in the collection search dropdown don't adjust to the zoom level in Geometry nodes editor.Mar 13 2021, 10:04 PM
Charlie Jolly (charlie) mentioned this in T86749: Geometry Node Community Additions.Mar 19 2021, 10:57 PM
Hans Goudey (HooglyBoogly) added a reviewer: Nathan Craddock (natecraddock).Mar 26 2021, 9:34 PM
Hans Goudey (HooglyBoogly) added subscribers: Nathan Craddock (natecraddock), Hans Goudey (HooglyBoogly).

Hey @Nathan Craddock (natecraddock), I have a feeling this is pretty straightforward, but maybe you want to look at this one?

Nathan Craddock (natecraddock) accepted this revision as: Nathan Craddock (natecraddock).Apr 7 2021, 3:08 AM

@Hans Goudey (HooglyBoogly) thanks for the heads up.

@Leon Schittek (lone_noel) thanks for the patch! I just tested and everything looks good from what I can see.

This revision is now accepted and ready to land.Apr 7 2021, 3:08 AM
Julian Eisel (Severin) accepted this revision.Apr 7 2021, 11:19 AM
Closed by commit rB965425bcbc4d: Fix T86463: Colored collection icons don't scale with zoom level (authored by Leon Leno <lone_noel>, committed by Nathan Craddock (natecraddock)). · Explain WhyApr 7 2021, 4:58 PM
This revision was automatically updated to reflect the committed changes.
Nathan Craddock (natecraddock) added a commit: rB965425bcbc4d: Fix T86463: Colored collection icons don't scale with zoom level.

Revision Contents
Changeset List

PathSize
source/
blender/
editors/
interface/
6 lines

Diff 35125

View Options

source/blender/editors/interface/interface_icons.c

Loading...