Fix: Re-add legacy document icon on macOS
ClosedPublic
Actions

Authored by Johannes Jakob (johjakob) on Mar 17 2021, 12:02 PM.

Details

Reviewers

Group Reviewers

Platform: macOS
User Interface

Commits

rB4b9c9a7bea4a: Fix missing document icons on macOS 10.4 and earlier

Summary

Re-adds a legacy document icon for macOS 10.14 Mojave that is
consistent with the system generated document icon on macOS 11
Big Sur. It uses the old-style document sheet icon, but includes the
file extension underneath the Blender icon (unlike the previous
legacy document icon that was removed in D10267).

Adds the missing description for the exported type identifier.
Finder now correctly displays “Blender File” instead of “data”
for Blender files.

Diff Detail

Repository

rB Blender

Branch

mac-fix-document-icon (branched from master)

Build Status

Buildable 13565
Build 13565: arc lint + arc unit

Event Timeline

Johannes Jakob (johjakob) requested review of this revision.Mar 17 2021, 12:02 PM

Johannes Jakob (johjakob) created this revision.

Harbormaster completed remote builds in B13565: Diff 35300.Mar 17 2021, 12:02 PM

This new legacy document icon for macOS 10.14 Mojave and earlier is now more in line with macOS’s Human Interface Guidelines and consistent with the system generated document icon on macOS 11 Big Sur.

Johannes Jakob (johjakob) added reviewers: Platform: macOS, User Interface.Mar 17 2021, 12:17 PM

Johannes Jakob (johjakob) added projects: Platform: macOS, User Interface.

In rB54a4eb5e17f8de65e94e17ffc269e8c5a6baff15#298267, @Ankit Meel (ankitm) wrote:

On macOS 10.14, the blend file icons are empty.
I reverted this commit, built and launched Blender, and icons were back.

master master with this commit reverted

@Johannes Jakob (johjakob) said in chat that he's looking into it.